Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] on a 413 throw a RequestEntity Too Large Error #18181

Merged
4 commits merged into from
Apr 20, 2021

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft self-assigned this Apr 20, 2021
@ghost ghost added the Tables label Apr 20, 2021
@@ -6,6 +6,7 @@
from azure.data.tables._models import TableServiceStats

from ._entity import TableEntity, EntityProperty, EdmType
from ._error import RequestEntityTooLargeError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer RequestTooLargeError
Entity already means something different in the Tables context :)

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Changelog update? ;)

@seankane-msft seankane-msft linked an issue Apr 20, 2021 that may be closed by this pull request
@ghost
Copy link

ghost commented Apr 20, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 355c45c into Azure:master Apr 20, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 22, 2021
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits)
  update FormField docstring (Azure#18226)
  [Event Hubs] combine conn str parsing logic (Azure#18059)
  [Blob]Edit Test for Single Thread Substream Retry (Azure#18206)
  maintenance changelog config (Azure#18216)
  Privated hierarchy traversal and fixed encryption algorithm (Azure#18212)
  Remove duplicate calls to bypass-local-dns.yml (Azure#18180)
  Patch changelog (Azure#18188)
  enable polling by default (Azure#18184)
  [Communication]: Added identity exception tests (Azure#18191)
  version (Azure#18202)
  [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166)
  Updated identity samples (Azure#18189)
  Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155)
  Clean Up PR Triggers (Azure#18186)
  [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181)
  Add environment.yml to unify conda versioning (Azure#18141)
  [Fix]Add retry for streaming download (Azure#18164)
  Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178)
  Stop filtering projects by ci.yml files (Azure#18174)
  [Communication] - SDK - Added contributing file (Azure#18018)
  ...
@seankane-msft seankane-msft deleted the tables-413 branch May 18, 2021 16:12
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 15, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 15, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tables] Add a 413 error for batches with too large entities
2 participants