Remove explicit version tag from automation #10002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Feb 26, 2020
| @@ -2,7 +2,6 @@ | |||
| "$schema": "https://openapistorageprod.blob.core.windows.net/sdkautomation/prod/schemas/swagger_to_sdk_config.schema.json", | |||
| "meta": { | |||
| "autorest_options": { | |||
| "version": "preview", | |||
There was a problem hiding this comment.
For now this would need to be 2.0.4413, or 'previous', until the polling for ttags is fixed. Would also need a similar fix in the AzureSDKAutomation fork of the repo
There was a problem hiding this comment.
version:V2 might be the safest bet.
That at least won't float arbitrarily.
There was a problem hiding this comment.
Moved to "V2" per @fearthecowboy suggestion
markcowl
approved these changes
Feb 26, 2020
|
@markcowl Damn you're right I did the mistake myself..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not mess up autorest v3 CLI detection of needed core