Open
Description
openedon Jun 8, 2023
See #30089:
- the
azure-monitor-opentelemetry
depends onazure-monitoring-opentelemetry-exporter
. which in turn depends onazure-core
- API view was not generated in the original version of Migrating azure-monitor-opentelemetry to azure-sdk #30089
- in this initial pipeline run, "Detect API changes" step decided API view is not necessary
Is API change detect required for azure-monitor-opentelemetry:False
- investigation has shown that package info json had
IsNewSdk
set tofalse
since there is no direct dependency onazure-core
that parse_setup script could detect.
Adding direct dependency to azure-core
solved the problem.
There could be a room for improvement here:
- detect transitive dependencies
- allow explicit configuration for
isNewSdk
property (or another one to force API view creation) - document that all new SDKs MUST depend on azure-core directly in contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment