Skip to content

API View is not created when dependency on azure-core is transitive #30689

Open

Description

See #30089:

  • the azure-monitor-opentelemetry depends on azure-monitoring-opentelemetry-exporter. which in turn depends on azure-core
  • API view was not generated in the original version of Migrating azure-monitor-opentelemetry to azure-sdk #30089
  • in this initial pipeline run, "Detect API changes" step decided API view is not necessary Is API change detect required for azure-monitor-opentelemetry:False
  • investigation has shown that package info json had IsNewSdk set to false since there is no direct dependency on azure-core that parse_setup script could detect.

Adding direct dependency to azure-core solved the problem.

There could be a room for improvement here:

  • detect transitive dependencies
  • allow explicit configuration for isNewSdk property (or another one to force API view creation)
  • document that all new SDKs MUST depend on azure-core directly in contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

ClientThis issue points to a problem in the data-plane of the library.EngSysThis issue is impacting the engineering system.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions