Skip to content

[SchemaRegistry] arch boarding review feedback #20703

Closed

Description

Azure/azure-sdk#3303

SchemaRegistry

  • discuss with feature crew about combining register_schema and get_schema_properties
  • update all discussed positional args to required keyword args + move Schema/SchemaProperties params to kwargs
  • remove cache on client
  • rename SerializationType to SchemaFormat + serialization_type to format
  • rename content to schema_definition
  • Rename endpoint to fully_qualified_namespace on client
  • Investigate using BinaryData instead of string as the type for the content parameter and property type in SchemaRegistrySchema
  • Come up with guidance around the recommended use of AutoRegisterSchema and make sure it aligns with our default value.

AvroSerializer

  • make group_name required kwarg
  • make schema param in serialize a kwarg --> will allow us to add id kwarg later, if user wants to pass in schema_id instead.
  • change Dict to Mapping in avro serialize method

.NET issue: Azure/azure-sdk-for-net#24035
JS issue: Azure/azure-sdk-for-js#17697
Python:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.MessagingMessaging crewSchema Registryblocking-releaseBlocks release

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions