[Key Vault] Remove x509_thumbprint_string property (#34386)

Author: mccoyp

sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md

@@ -6,6 +6,9 @@
 - Added support for service API version `7.5`
 
 ### Breaking Changes
+> These changes do not impact the API of stable versions such as 4.7.0. Only code written against a beta version such as 4.8.0b2 may be affected.
+- Removed `CertificateProperties.x509_thumbprint_string`. To get the certificate's thumbprint in hex, use
+  `CertificateProperties.x509_thumbprint.hex()` or print the `CertificateProperties` instance.
 
 ### Bugs Fixed
 

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_models.py

@@ -144,7 +144,7 @@ def __init__(self, **kwargs: Any) -> None:
         self._tags = kwargs.pop("tags", None)
 
     def __repr__(self) -> str:
-        return f"<CertificateProperties [{self.id}]>"[:1024]
+        return f"<CertificateProperties [{self._x509_thumbprint.hex().upper()}]>"[:1024]
 
     @classmethod
     def _from_certificate_item(
@@ -254,22 +254,13 @@ def vault_url(self) -> str:
     def x509_thumbprint(self) -> bytes:
         """The certificate's thumbprint, in bytes.
 
+        To get the thumbprint as a hexadecimal string, call ``.hex()`` on this property.
+
         :return: The certificate's thumbprint, in bytes.
         :rtype: bytes
         """
         return self._x509_thumbprint
 
-    @property
-    def x509_thumbprint_string(self) -> str:
-        """The certificate's thumbprint, as a hexadecimal string.
-
-        The thumbprint is formatted without colon delimiters; e.g. 76E1819FADF06A55EF4B126A2EF743C2BAE8A151.
-
-        :return: The certificate's thumbprint, as a hexadecimal string.
-        :rtype: str
-        """
-        return self._x509_thumbprint.hex().upper()
-
     @property
     def tags(self) -> Optional[Dict[str, str]]:
         """Application specific metadata in the form of key-value pairs.

sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py

@@ -774,9 +774,9 @@ def test_case_insensitive_key_type():
 
 
 def test_thumbprint_hex():
-    """Ensure the `CertificateProperties.x509_thumbprint_string` property correctly converts a thumbprint to hex."""
+    """Ensure `CertificateProperties.__repr__()` correctly displays the cert's thumbprint as hex."""
     properties = CertificateProperties(
         cert_id="https://vaultname.vault.azure.net/certificates/certname/version",
         x509_thumbprint=b"v\xe1\x81\x9f\xad\xf0jU\xefK\x12j.\xf7C\xc2\xba\xe8\xa1Q",
     )
-    assert properties.x509_thumbprint_string == "76E1819FADF06A55EF4B126A2EF743C2BAE8A151"
+    assert "76E1819FADF06A55EF4B126A2EF743C2BAE8A151" in str(properties)