[EH] Emulator prep for release (#35623)

* remove check

* update conn tests

* no longer validate localhost

* import err

* Update sdk/eventhub/azure-eventhub/CHANGELOG.md

* Update sdk/eventhub/azure-eventhub/CHANGELOG.md

Author: l0lawrence

sdk/eventhub/azure-eventhub/CHANGELOG.md

@@ -1,14 +1,10 @@
 # Release History
 
-## 5.11.8 (Unreleased)
+## 5.12.0 (2024-05-16)
 
 ### Features Added
 
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
+- Added support for non-tls connections (#34272)
 
 ## 5.11.7 (2024-04-10)
 

sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py

@@ -9,7 +9,6 @@
 import time
 import functools
 import collections
-import re
 from typing import Any, Dict, Tuple, List, Optional, TYPE_CHECKING, cast, Union
 from datetime import timedelta
 from urllib.parse import urlparse
@@ -69,9 +68,6 @@
 _LOGGER = logging.getLogger(__name__)
 _Address = collections.namedtuple("_Address", "hostname path")
 
-def _is_local_endpoint(endpoint: str) -> bool:
-    return re.match("^(127\\.[\\d.]+|[0:]+1|localhost)", endpoint.lower()) is not None
-
 def _parse_conn_str(
         conn_str: str,  # pylint:disable=unused-argument
         *,
@@ -137,13 +133,6 @@ def _parse_conn_str(
     host = cast(str, parsed.netloc.strip())
 
     emulator = use_emulator=="true"
-    if emulator and not _is_local_endpoint(host):
-        raise ValueError(
-            "Invalid endpoint on the connection string. "
-            "For development connection strings, should be in the format: "
-            "Endpoint=sb://localhost;SharedAccessKeyName=<KeyName>;SharedAccessKey=<KeyValue>;"
-            "UseDevelopmentEmulator=true;"
-        )
 
     if any([shared_access_key, shared_access_key_name]) and not all(
         [shared_access_key, shared_access_key_name]

sdk/eventhub/azure-eventhub/tests/unittest/test_connection_string_parser.py

@@ -125,13 +125,6 @@ def test_eh_emulator_slug_parse_localhost(self, **kwargs):
         assert emulator == True
 
 
-    def test_eh_emulator_slug_parse_not_localhost(self, **kwargs):
-        conn_str = 'Endpoint=sb://resourcename.servicebus.windows.net;SharedAccessKeyName=test-policy;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=;UseDevelopmentEmulator=true'
-        with pytest.raises(ValueError) as e:
-            fully_qualified_namespace, policy, key, entity, signature, expiry, emulator = _parse_conn_str(
-                conn_str
-            )
-
     def test_eh_emulator_slug_parse_ipv6(self, **kwargs):
         conn_str = 'Endpoint=sb://::1;SharedAccessKeyName=test-policy;SharedAccessKey=THISISATESTKEYXXXXXXXXXXXXXXXXXXXXXXXXXXXX=;UseDevelopmentEmulator=true'
         fully_qualified_namespace, policy, key, entity, signature, expiry, emulator = _parse_conn_str(