From 692b9c0f9c21691638e48cb99dac3eda4021b90d Mon Sep 17 00:00:00 2001 From: Sharath Malladi Date: Fri, 7 Oct 2022 15:09:59 -0700 Subject: [PATCH] Addressed more feedback comments. --- .../azure/ai/personalizer/_patch.py | 6 ++++-- .../azure/ai/personalizer/aio/_patch.py | 10 ++++------ .../ai/personalizer/aio/operations/_operations.py | 6 +++--- .../azure/ai/personalizer/operations/_operations.py | 6 +++--- .../multi_slot_rank_actions_and_reward_events_async.py | 1 + .../rank_actions_and_reward_events_async.py | 1 + .../multi_slot_rank_actions_and_reward_events.py | 1 + .../samples/rank_actions_and_reward_events.py | 1 + .../azure-ai-personalizer/swagger/README.md | 3 +++ sdk/personalizer/{azure-ai-personalizer => }/tests.yml | 1 - 10 files changed, 21 insertions(+), 15 deletions(-) rename sdk/personalizer/{azure-ai-personalizer => }/tests.yml (96%) diff --git a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/_patch.py b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/_patch.py index aec4eac1cdc3..c8b72181ae90 100644 --- a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/_patch.py +++ b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/_patch.py @@ -11,7 +11,10 @@ from azure.core.pipeline.policies import AzureKeyCredentialPolicy, BearerTokenCredentialPolicy from ._client import PersonalizerClient as PersonalizerClientGenerated -__all__ = ["PersonalizerClient"] # Add all objects you want publicly available to users at this package level +__all__: List[str] = [ + "PersonalizerClient" +] # Add all objects you want publicly available to users at this package level + def _authentication_policy(credential, **kwargs): if credential is None: @@ -73,7 +76,6 @@ def __init__(self, endpoint: str, credential: Union[AzureKeyCredential, TokenCre authentication_policy=kwargs.pop("authentication_policy", _authentication_policy(credential, **kwargs)), **kwargs ) - self._default_language = kwargs.pop("default_language", None) def patch_sdk(): diff --git a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/_patch.py b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/_patch.py index ea89b1266e9c..9ede0b38c48c 100644 --- a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/_patch.py +++ b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/_patch.py @@ -12,7 +12,10 @@ from azure.core.pipeline.policies import AzureKeyCredentialPolicy, AsyncBearerTokenCredentialPolicy from ._client import PersonalizerClient as PersonalizerClientGenerated -__all__: List[str] = [] # Add all objects you want publicly available to users at this package level +__all__: List[str] = [ + "PersonalizerClient" +] # Add all objects you want publicly available to users at this package level + def _authentication_policy(credential, **kwargs): if credential is None: @@ -80,11 +83,6 @@ def __init__( self._default_language = kwargs.pop("default_language", None) -__all__: List[str] = [ - "PersonalizerClient" -] # Add all objects you want publicly available to users at this package level - - def patch_sdk(): """Do not remove from this file. diff --git a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/operations/_operations.py b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/operations/_operations.py index 8822d744580b..3f40be9ee256 100644 --- a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/operations/_operations.py +++ b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/aio/operations/_operations.py @@ -42,7 +42,7 @@ build_log_get_properties_request, build_model_get_properties_request, build_model_get_request, - build_model_import_method_request, + build_model_import_model_request, build_model_reset_request, build_multi_slot_events_activate_request, build_multi_slot_events_reward_request, @@ -2139,7 +2139,7 @@ async def get(self, *, signed: bool = False, **kwargs: Any) -> AsyncIterator[byt return cast(AsyncIterator[bytes], deserialized) @distributed_trace_async - async def import_method(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inconsistent-return-statements + async def import_model(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inconsistent-return-statements """Model File. Replace the existing model file for the Personalizer service. @@ -2166,7 +2166,7 @@ async def import_method(self, body: IO, **kwargs: Any) -> None: # pylint: disab _content = body - request = build_model_import_method_request( + request = build_model_import_model_request( content_type=content_type, api_version=self._config.api_version, content=_content, diff --git a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/operations/_operations.py b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/operations/_operations.py index d574050b167f..9bfa190427ea 100644 --- a/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/operations/_operations.py +++ b/sdk/personalizer/azure-ai-personalizer/azure/ai/personalizer/operations/_operations.py @@ -488,7 +488,7 @@ def build_model_get_request(*, signed: bool = False, **kwargs: Any) -> HttpReque return HttpRequest(method="GET", url=_url, params=_params, headers=_headers, **kwargs) -def build_model_import_method_request(*, content: IO, **kwargs: Any) -> HttpRequest: +def build_model_import_model_request(*, content: IO, **kwargs: Any) -> HttpRequest: _headers = case_insensitive_dict(kwargs.pop("headers", {}) or {}) _params = case_insensitive_dict(kwargs.pop("params", {}) or {}) @@ -2716,7 +2716,7 @@ def get(self, *, signed: bool = False, **kwargs: Any) -> Iterator[bytes]: return cast(Iterator[bytes], deserialized) @distributed_trace - def import_method(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inconsistent-return-statements + def import_model(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inconsistent-return-statements """Model File. Replace the existing model file for the Personalizer service. @@ -2743,7 +2743,7 @@ def import_method(self, body: IO, **kwargs: Any) -> None: # pylint: disable=inc _content = body - request = build_model_import_method_request( + request = build_model_import_model_request( content_type=content_type, api_version=self._config.api_version, content=_content, diff --git a/sdk/personalizer/azure-ai-personalizer/samples/async_samples/multi_slot_rank_actions_and_reward_events_async.py b/sdk/personalizer/azure-ai-personalizer/samples/async_samples/multi_slot_rank_actions_and_reward_events_async.py index 9ce295afdb43..354cc4101f3e 100644 --- a/sdk/personalizer/azure-ai-personalizer/samples/async_samples/multi_slot_rank_actions_and_reward_events_async.py +++ b/sdk/personalizer/azure-ai-personalizer/samples/async_samples/multi_slot_rank_actions_and_reward_events_async.py @@ -11,6 +11,7 @@ DESCRIPTION: This sample demos sending a rank and reward call to personalizer for multi-slot configuration. USAGE: python multi_slot_rank_actions_and_reward_events_async.py +Environment variables PERSONALIZER_ENDPOINT and PERSONALIZER_API_KEY must be set as per your personalizer instance. """ import asyncio import os diff --git a/sdk/personalizer/azure-ai-personalizer/samples/async_samples/rank_actions_and_reward_events_async.py b/sdk/personalizer/azure-ai-personalizer/samples/async_samples/rank_actions_and_reward_events_async.py index 3e6e5f9030aa..6fd821e6f13b 100644 --- a/sdk/personalizer/azure-ai-personalizer/samples/async_samples/rank_actions_and_reward_events_async.py +++ b/sdk/personalizer/azure-ai-personalizer/samples/async_samples/rank_actions_and_reward_events_async.py @@ -11,6 +11,7 @@ DESCRIPTION: This sample demos sending a rank and reward call to personalizer USAGE: python rank_actions_and_reward_events_async.py +Environment variables PERSONALIZER_ENDPOINT and PERSONALIZER_API_KEY must be set as per your personalizer instance. """ import asyncio import os diff --git a/sdk/personalizer/azure-ai-personalizer/samples/multi_slot_rank_actions_and_reward_events.py b/sdk/personalizer/azure-ai-personalizer/samples/multi_slot_rank_actions_and_reward_events.py index 6b58d603ca82..aad9412fd3e6 100644 --- a/sdk/personalizer/azure-ai-personalizer/samples/multi_slot_rank_actions_and_reward_events.py +++ b/sdk/personalizer/azure-ai-personalizer/samples/multi_slot_rank_actions_and_reward_events.py @@ -11,6 +11,7 @@ DESCRIPTION: This sample demos sending a rank and reward call to personalizer for multi-slot configuration. USAGE: python multi_slot_rank_actions_and_reward_events.py +Environment variables PERSONALIZER_ENDPOINT and PERSONALIZER_API_KEY must be set as per your personalizer instance. """ import os diff --git a/sdk/personalizer/azure-ai-personalizer/samples/rank_actions_and_reward_events.py b/sdk/personalizer/azure-ai-personalizer/samples/rank_actions_and_reward_events.py index 49ef897c6529..a1f8a9f212c5 100644 --- a/sdk/personalizer/azure-ai-personalizer/samples/rank_actions_and_reward_events.py +++ b/sdk/personalizer/azure-ai-personalizer/samples/rank_actions_and_reward_events.py @@ -11,6 +11,7 @@ DESCRIPTION: This sample demos sending a rank and reward call to personalizer USAGE: python rank_actions_and_reward_events.py +Environment variables PERSONALIZER_ENDPOINT and PERSONALIZER_API_KEY must be set as per your personalizer instance. """ import os import sys diff --git a/sdk/personalizer/azure-ai-personalizer/swagger/README.md b/sdk/personalizer/azure-ai-personalizer/swagger/README.md index 5fdd8912cf27..441e3a95ee3b 100644 --- a/sdk/personalizer/azure-ai-personalizer/swagger/README.md +++ b/sdk/personalizer/azure-ai-personalizer/swagger/README.md @@ -49,5 +49,8 @@ directive: - where-operation: Evaluations_List transform: > $.parameters[1]["x-ms-client-name"] = "filter_expression"; + - rename-operation: + from: Model_Import + to: Model_ImportModel ``` diff --git a/sdk/personalizer/azure-ai-personalizer/tests.yml b/sdk/personalizer/tests.yml similarity index 96% rename from sdk/personalizer/azure-ai-personalizer/tests.yml rename to sdk/personalizer/tests.yml index b06048bf135e..cbc4da56ecd6 100644 --- a/sdk/personalizer/azure-ai-personalizer/tests.yml +++ b/sdk/personalizer/tests.yml @@ -7,7 +7,6 @@ stages: ServiceDirectory: personalizer MatrixReplace: - TestSamples=.*/true - Clouds: Canary EnvVars: AZURE_CLIENT_ID: $(PERSONALIZER_CLIENT_ID) AZURE_TENANT_ID: $(PERSONALIZER_TENANT_ID)