Skip to content

Commit 1f7dd2b

Browse files
authored
[Identity] Update integration test Dockerfiles (#36480)
Ensure that we are pulling images from MCR so that we do not hit rate limits. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
1 parent 2844d0a commit 1f7dd2b

File tree

2 files changed

+6
-8
lines changed
  • sdk/identity/azure-identity/tests/integration

2 files changed

+6
-8
lines changed

sdk/identity/azure-identity/tests/integration/azure-functions/Dockerfile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
# ------------------------------------
55
# docker can't tell when the repo has changed and will therefore cache this layer
66

7-
# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
8-
# public OSS users should simply leave this argument blank or ignore its presence entirely
9-
ARG REGISTRY=""
7+
# public OSS users should make this an empty string: 'docker build . --build-arg REGISTRY=""'
8+
ARG REGISTRY="mcr.microsoft.com/mirror/docker/library/"
109

11-
FROM ${REGISTRY}alpine:3.19 as repo
10+
FROM ${REGISTRY}alpine:3.16 AS repo
1211
RUN apk --no-cache add git
1312
RUN git clone https://github.com/Azure/azure-sdk-for-python --single-branch --depth 1 /azure-sdk-for-python
1413

sdk/identity/azure-identity/tests/integration/azure-kubernetes-service/Dockerfile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
# ------------------------------------
55
# docker can't tell when the repo has changed and will therefore cache this layer
66

7-
# internal users should provide MCR registry to build via 'docker build . --build-arg REGISTRY="mcr.microsoft.com/mirror/docker/library/"'
8-
# public OSS users should simply leave this argument blank or ignore its presence entirely
9-
ARG REGISTRY=""
7+
# public OSS users should make this an empty string: 'docker build . --build-arg REGISTRY=""'
8+
ARG REGISTRY="mcr.microsoft.com/mirror/docker/library/"
109

11-
FROM ${REGISTRY}alpine:3.19 as repo
10+
FROM ${REGISTRY}alpine:3.16 AS repo
1211
RUN apk --no-cache add git
1312
RUN git clone https://github.com/Azure/azure-sdk-for-python --single-branch --depth 1 /azure-sdk-for-python
1413

0 commit comments

Comments
 (0)