Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double dots in template file name extensions #33520

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

heaths
Copy link
Member

@heaths heaths commented Jan 16, 2023

Fixes #33515 and may be solution or work around to dotnet/templating#5955

Fixes Azure#33515 and may be solution or work around to dotnet/sdk#29962
@ghost ghost added the EngSys This issue is impacting the engineering system. label Jan 16, 2023
@heaths
Copy link
Member Author

heaths commented Jan 16, 2023

This may fix or at least work around the problem. In testing with tree /f, I don't see any double dots after this. File names appear right, but it may be good to pull this branch and test it with the automation process. If you have the GitHub CLI you can run gh pr clone #33520, or you can add my remote to your local clone and checkout my branch e.g., git remote add heaths https://github.com/heaths/azure-sdk-for-net.git && git fetch heaths && git checkout heaths/issue33515.

@heaths
Copy link
Member Author

heaths commented Jan 16, 2023

Note: I also formatted the document since editors like VSCode are going to at least reformat code one modifies. In general, it's best to keep code formatted so frequent re-formatting doesn't happen.

If you look at the PR and hide whitespace changes, you'll find it's very small.

sdk/template/.template.config/template.json Outdated Show resolved Hide resolved
@chunyu3
Copy link
Member

chunyu3 commented Jan 17, 2023

Hello @heaths I tried this solution in test env, it works. After the PR is merged, I will try it in prod env. Thanks.

@heaths
Copy link
Member Author

heaths commented Jan 17, 2023

@chunyu3 can you test this again? I generated a new version and checked a few files' contents, but a more thorough test like you did last night would be great.

@chunyu3
Copy link
Member

chunyu3 commented Jan 18, 2023

@chunyu3 can you test this again? I generated a new version and checked a few files' contents, but a more thorough test like you did last night would be great.

Hello @heaths I have tried in test env, it works. Thanks

@heaths heaths merged commit d8e17af into Azure:main Jan 18, 2023
@heaths heaths deleted the issue33515 branch January 18, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "dotnet new azsdkdpg" generate unexpected file after PR 32814
3 participants