[Search] Add missing property when cloning SearchOptions

[Mohit-Chakraborty]

Copy all properties using reflection to alleviate the issue of missing some properties in the copy code.

[Mohit-Chakraborty]

/azp run net - search - tests

[Mohit-Chakraborty]

/azp run net - search - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Mohit-Chakraborty]

Issue #27549

[Mohit-Chakraborty]

Issue #27549

This is the category of issues I am trying to kill with this approach. It has happened a few times now. The current issue is for an old property, so the bug has existed for a while.

[Mohit-Chakraborty]

/azp run net - search - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Mohit-Chakraborty]

cc: @tg-msft
What do you think of this solution? Alternatively, we could add the one we know is missing currently and be more diligent in the future.

[JoshLove-msft]

It looks like these are all value types, would a MemberwiseClone work?

[JoshLove-msft]

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

[Mohit-Chakraborty]

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

What would the test check? The count of the properties?

[JoshLove-msft]

Another idea would be to just do the reflection in the unit test, and keep the production code up to date by hand. This way you will catch future missing properties automatically in the test, but won't have to use reflection in production code.

What would the test check? The count of the properties?

The test could check that each property on the source is equal to the corresponding property on the destination.

[azure-sdk]

API change check for Azure.Search.Documents

API changes are not detected in this pull request for Azure.Search.Documents