Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web PubSub] Remove the --prerelease switch from GAing library #25304

Merged
merged 2 commits into from
Nov 15, 2021
Merged

[Web PubSub] Remove the --prerelease switch from GAing library #25304

merged 2 commits into from
Nov 15, 2021

Conversation

Mohit-Chakraborty
Copy link
Contributor

No description provided.

@Mohit-Chakraborty
Copy link
Contributor Author

Mohit-Chakraborty commented Nov 12, 2021 •
edited
Loading

Should we cherry-pick this commit to the release tag branch?
Turns out it is not a recommended practice. It will involve deleting the tag (for us 'Azure.Messaging.WebPubSub_1.0.0'), creating a new one by the same name for the new commit and pushing the changes. Not sure we want to do all that.

@Mohit-Chakraborty Mohit-Chakraborty merged commit 7addfa9 into main Nov 15, 2021
@Mohit-Chakraborty Mohit-Chakraborty deleted the mohitc/RemovePrerelease branch November 15, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy vicancy approved these changes

@JialinXin JialinXin Awaiting requested review from JialinXin JialinXin is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mohit-Chakraborty @vicancy