Move RequestOptions and related types to Azure.Core #24945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
annelo-msft
requested review from
tg-msft,
ShivangiReja,
ellismg,
AlexanderSher,
Mohit-Chakraborty and
lmazuel
pakrym
reviewed
Oct 26, 2021
pakrym
reviewed
Oct 26, 2021
pakrym
reviewed
Oct 26, 2021
|
API changes have been detected in |
Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
pakrym
reviewed
Oct 27, 2021
|
API changes have been detected in |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to release WebPubSub without a dependency on Azure.Core.Experimental, we need to move the following three types to Azure.Core:
RequestOptions(nowRequestContext)ResponseStatusOptions(nowErrorOptions)ContentTypeThis is the first PR in this process, and adds
RequestContextandErrorOptionsto Core. Subsequent PRs will update the generator and removeContentTypefrom Core.Experimental and move it to Core.