Plugged source of account leak #24929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLW tests are tricky in how they need to handle container create/delete. PR 24351 introduced a bug where we would try to access null when tearing down those containers, making it impossible to delete the account. As this happened in a teardown step, NUnit/DevOps didn't properly report these exceptions to us. We no longer access what was causing the null exeption.
jaschrep-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft,
seanmcc-msft and
tg-msft
as code owners
ghost
added
the
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kasobol-msft
approved these changes
Oct 26, 2021
amnguye
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLW tests are tricky in how they need to handle container create/delete. #24351 introduced a bug where we would try to access null when tearing down those containers, making it impossible to delete the account. As this happened in a global teardown step, NUnit/DevOps didn't properly report these exceptions to us.
We no longer access the null property in that global teardown. Confirmed accounts now get deleted in the scenario that causes the property to be null.