-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added C# example to create complex index #24589
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These snippets are actually declared in-source, for example, search for "Snippet:Azure_Search_Tests_Samples_Readme_CreateManualIndex" like the snippet directly above. We do this to ensure that samples compile and most often run them during testing to make sure they work (and continue to work) correctly.
We also try to keep the most common scenarios in the README to avoid it getting too large. It might be better to instead add a sample under Azure.Search.Documents/test/samples, along with corresponding markdown files in Azure.Search.Documents/samples.
I can help you with that, if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, instead of a new sample, we could also update one of the existing Hotel samples to add a complex field. This would have the additional benefit that it's already incorporated into existing samples instead of being an entirely separate one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's ok either approach, but i really think to have a list of objects it's not that uncommon.
This is just the first time i used Azure Search and almost immediately i needed a list of objects, that's why I think there is a lack of documentation and tried to add it here.
If you prefer me to modify one of the samples it's ok, could you please point me to the most appropriate one 😄?
Thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heaths Over 10% of indexes used in the past 7 days have complex fields, so it's not uncommon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could include it in an existing sample, then, but 1) sample snippets in markdowns should not be code-complete samples, and 2) need to use the same syntax to make sure they are testable. I think modifying the Hotels sample would be ideal, and make sure the existing snippets show an example of complex types. I don't think it warrants a completely separate sample.
@Mohit-Chakraborty @tg-msft ?