Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize Azure.Core HTTP Activity URL #24545

Merged
merged 2 commits into from
Oct 26, 2021
+58 −24
Merged

Sanitize Azure.Core HTTP Activity URL #24545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d53ac32
Sanitize Activity URL
pakrym Oct 7, 2021
b18f18e
fb
pakrym Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fb
  • Loading branch information
@pakrym
pakrym committed Oct 25, 2021
commit b18f18e55bba6ecfe7bdfb0f02b40912170a0115
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/RequestActivityPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public async Task UriAttributeIsSanitized()
await requestTask;

CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("http.url", "http://example.com/?api-version=v2&sas=REDACTED"));
CollectionAssert.IsEmpty(activity.Tags.Where(kvp => kvp.Value.Contains("secret")));
}

[Test]
Expand Down