-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage test infra refactor #24351
Merged
jaschrep-msft
merged 12 commits into
Azure:main
from
jaschrep-msft:storage/test-infra-refactor
Oct 5, 2021
Merged
Storage test infra refactor #24351
jaschrep-msft
merged 12 commits into
Azure:main
from
jaschrep-msft:storage/test-infra-refactor
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, this is going into right direction.
ServiceCLient getters are now in package-specific extensions instead of on the client builder directly. Property rename.
kasobol-msft
reviewed
Oct 5, 2021
sdk/storage/Azure.Storage.Common/tests/Shared/StorageTestBase.cs
Outdated
Show resolved
Hide resolved
seanmcc-msft
reviewed
Oct 5, 2021
sdk/storage/Azure.Storage.Blobs.Batch/tests/BlobBatchClientTests.cs
Outdated
Show resolved
Hide resolved
kasobol-msft
approved these changes
Oct 5, 2021
seanmcc-msft
approved these changes
Oct 5, 2021
This was referenced Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls some basics of client tests out of
XxxTestBase
hierarchy and into separate utility classes so they can be accessed outside of said hierarchy. Useful for writing unified tests across multiple Storage services without excessive code duplication.Key Changes:
TenantConfigurationBuilder
houses code previously inStorageTestBase
that grabsTenantConfiguration
s out of a config file.ClientBuilder
houses genericized code previously inBlobTestBase
/DataLakeTestBase
/etc. that createsXxxServiceClient
s out of results fromTenantConfigurationBuilder
.ClientBuilderExtensions
class that decorates theClientBuilder
with functionality that doesn't fit easy into generics.Notes to reviewers:
RecordedTestBase
, and so we still have to pass in an instance of that. We need access to theRecording
management andInstrumentClient
. Not ideal but still a significant improvement.