Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Backup Health #12543

Merged
merged 12 commits into from
Jun 15, 2020
Merged

Azure Backup Health #12543

merged 12 commits into from
Jun 15, 2020

Conversation

lapradh
Copy link
Contributor

@lapradh lapradh commented Jun 5, 2020

Updated health details

openapi spec review PR : Azure/azure-rest-api-specs#9711
Check in the metadata TXT file generated when you run generate.ps1(details) : Done
Update api tag in AzSdk.RP.props, release notes in csproj : updated release notes.
Update versions in csproj and assemblyinfo.cs if you are going to release : no new version. so not required.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lapradh , could you

  • Add a link to the openapi spec review PR here
  • Check in the metadata TXT file generated when you run generate.ps1(details)
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Jun 5, 2020
@lapradh
Copy link
Contributor Author

lapradh commented Jun 5, 2020

Swagger PR : Azure/azure-rest-api-specs#9711

Comment on lines 12 to 21
<PackageReleaseNotes>
<![CDATA[
New features:
- Added changes for Azure Backup Health.
]]>
<![CDATA[
New features:
- Added 4 new rest api related to private endpoint connection work (JEDI).
]]>
</PackageReleaseNotes>
Copy link
Member

@isra-fel isra-fel Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lapradh this looks like a bad merge. There should be only one <![CDATA[ ]]> block within <PackageReleaseNotes>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls review now

@isra-fel
Copy link
Member

And please also resolve the conflicts, as another PR of recovery service backup is merged #12650

@lapradh
Copy link
Contributor Author

lapradh commented Jun 12, 2020

/check-enforcer reset

@lapradh
Copy link
Contributor Author

lapradh commented Jun 12, 2020

/check-enforcer evaluate

@isra-fel
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 9f0cbfa into Azure:master Jun 15, 2020
prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
* Azure BAckup Health

* added metadata and release notes

* Revert "added metadata and release notes"

This reverts commit 4e3038b.

* Revert "Azure BAckup Health"

This reverts commit 3caab3e.

* heath kpi changes

* merge

* Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj

updated version to match latest

* Update AzureVmWorkloadSQLDatabaseProtectedItem.cs

added health details

* Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj

dummy check in

* Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj

dummy checkin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants