Skip to content

Commit be19245

Browse files
sarkar-rajarshisarkar-rajarshi
committed
address review feedback
1 parent 2e8e5ce commit be19245

File tree

51 files changed

+1857
-1290
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+1857
-1290
lines changed

‎sdk/communication/Azure.Communication.JobRouter/api/Azure.Communication.JobRouter.netstandard2.0.cs‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ public DeclineJobOfferOptions(string workerId, string offerId) { }
138138
public System.DateTimeOffset? ReofferTimeUtc { get { throw null; } set { } }
139139
public string WorkerId { get { throw null; } }
140140
}
141-
public partial class DeclineOfferRequest
141+
public partial class DeclineJobOfferRequest
142142
{
143-
public DeclineOfferRequest() { }
143+
public DeclineJobOfferRequest() { }
144144
public System.DateTimeOffset? ReofferTimeUtc { get { throw null; } set { } }
145145
}
146146
public partial class DirectMapRule : Azure.Communication.JobRouter.RouterRule
@@ -387,21 +387,21 @@ public RouterAdministrationClient(System.Uri endpoint, Azure.Core.TokenCredentia
387387
public virtual Azure.Pageable<Azure.Communication.JobRouter.Models.JobQueueItem> GetQueues(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
388388
public virtual Azure.AsyncPageable<Azure.Communication.JobRouter.Models.JobQueueItem> GetQueuesAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
389389
public virtual Azure.Response<Azure.Communication.JobRouter.Models.ClassificationPolicy> UpdateClassificationPolicy(Azure.Communication.JobRouter.UpdateClassificationPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
390-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.ClassificationPolicy> UpdateClassificationPolicy(string classificationPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
390+
public virtual Azure.Response UpdateClassificationPolicy(string classificationPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
391391
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.ClassificationPolicy>> UpdateClassificationPolicyAsync(Azure.Communication.JobRouter.UpdateClassificationPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
392-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.ClassificationPolicy>> UpdateClassificationPolicyAsync(string classificationPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
392+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateClassificationPolicyAsync(string classificationPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
393393
public virtual Azure.Response<Azure.Communication.JobRouter.Models.DistributionPolicy> UpdateDistributionPolicy(Azure.Communication.JobRouter.UpdateDistributionPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
394-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.DistributionPolicy> UpdateDistributionPolicy(string distributionPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
394+
public virtual Azure.Response UpdateDistributionPolicy(string distributionPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
395395
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.DistributionPolicy>> UpdateDistributionPolicyAsync(Azure.Communication.JobRouter.UpdateDistributionPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
396-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.DistributionPolicy>> UpdateDistributionPolicyAsync(string distributionPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
396+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateDistributionPolicyAsync(string distributionPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
397397
public virtual Azure.Response<Azure.Communication.JobRouter.Models.ExceptionPolicy> UpdateExceptionPolicy(Azure.Communication.JobRouter.UpdateExceptionPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
398-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.ExceptionPolicy> UpdateExceptionPolicy(string exceptionPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
398+
public virtual Azure.Response UpdateExceptionPolicy(string exceptionPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
399399
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.ExceptionPolicy>> UpdateExceptionPolicyAsync(Azure.Communication.JobRouter.UpdateExceptionPolicyOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
400-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.ExceptionPolicy>> UpdateExceptionPolicyAsync(string exceptionPolicyId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
400+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateExceptionPolicyAsync(string exceptionPolicyId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
401401
public virtual Azure.Response<Azure.Communication.JobRouter.Models.JobQueue> UpdateQueue(Azure.Communication.JobRouter.UpdateQueueOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
402-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.JobQueue> UpdateQueue(string queueId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
402+
public virtual Azure.Response UpdateQueue(string queueId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
403403
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.JobQueue>> UpdateQueueAsync(Azure.Communication.JobRouter.UpdateQueueOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
404-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.JobQueue>> UpdateQueueAsync(string queueId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
404+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateQueueAsync(string queueId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
405405
}
406406
public partial class RouterClient
407407
{
@@ -447,13 +447,13 @@ public RouterClient(System.Uri endpoint, Azure.Core.TokenCredential credential,
447447
public virtual Azure.Response<Azure.Communication.JobRouter.Models.UnassignJobResult> UnassignJob(Azure.Communication.JobRouter.UnassignJobOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
448448
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.UnassignJobResult>> UnassignJobAsync(Azure.Communication.JobRouter.UnassignJobOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
449449
public virtual Azure.Response<Azure.Communication.JobRouter.Models.RouterJob> UpdateJob(Azure.Communication.JobRouter.UpdateJobOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
450-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.RouterJob> UpdateJob(string jobId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
450+
public virtual Azure.Response UpdateJob(string jobId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
451451
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.RouterJob>> UpdateJobAsync(Azure.Communication.JobRouter.UpdateJobOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
452-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.RouterJob>> UpdateJobAsync(string jobId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
452+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateJobAsync(string jobId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
453453
public virtual Azure.Response<Azure.Communication.JobRouter.Models.RouterWorker> UpdateWorker(Azure.Communication.JobRouter.UpdateWorkerOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
454-
public virtual Azure.Response<Azure.Communication.JobRouter.Models.RouterWorker> UpdateWorker(string workerId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
454+
public virtual Azure.Response UpdateWorker(string workerId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
455455
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.RouterWorker>> UpdateWorkerAsync(Azure.Communication.JobRouter.UpdateWorkerOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
456-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.JobRouter.Models.RouterWorker>> UpdateWorkerAsync(string workerId, Azure.Core.RequestContent patchContent, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
456+
public virtual System.Threading.Tasks.Task<Azure.Response> UpdateWorkerAsync(string workerId, Azure.Core.RequestContent content, Azure.RequestContext context = null) { throw null; }
457457
}
458458
public partial class RouterClientOptions : Azure.Core.ClientOptions
459459
{
@@ -469,6 +469,12 @@ public abstract partial class RouterRule
469469
internal RouterRule() { }
470470
public string Kind { get { throw null; } set { } }
471471
}
472+
public enum RouterWorkerState
473+
{
474+
Active = 0,
475+
Draining = 1,
476+
Inactive = 2,
477+
}
472478
public partial class RuleEngineQueueSelectorAttachment : Azure.Communication.JobRouter.QueueSelectorAttachment
473479
{
474480
public RuleEngineQueueSelectorAttachment(Azure.Communication.JobRouter.RouterRule rule) { }
@@ -613,12 +619,6 @@ public abstract partial class WorkerSelectorAttachment
613619
internal WorkerSelectorAttachment() { }
614620
protected string Kind { get { throw null; } set { } }
615621
}
616-
public enum WorkerState
617-
{
618-
Active = 0,
619-
Draining = 1,
620-
Inactive = 2,
621-
}
622622
public enum WorkerStateSelector
623623
{
624624
Active = 0,
@@ -850,7 +850,7 @@ public RouterWorker() { }
850850
public double? LoadRatio { get { throw null; } }
851851
public System.Collections.Generic.IReadOnlyList<Azure.Communication.JobRouter.Models.JobOffer> Offers { get { throw null; } }
852852
public System.Collections.Generic.IDictionary<string, Azure.Communication.JobRouter.QueueAssignment> QueueAssignments { get { throw null; } set { } }
853-
public Azure.Communication.JobRouter.WorkerState? State { get { throw null; } }
853+
public Azure.Communication.JobRouter.RouterWorkerState? State { get { throw null; } }
854854
public System.Collections.Generic.IDictionary<string, Azure.Communication.JobRouter.LabelValue> Tags { get { throw null; } set { } }
855855
public int? TotalCapacity { get { throw null; } set { } }
856856
}

‎sdk/communication/Azure.Communication.JobRouter/samples/ClassificationPolicyCrud.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,12 @@ Console.WriteLine($"Classification policy successfully update with new prioritiz
8585
## Remove from classification policy
8686

8787
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateClassificationPolicyRemoveProp
88-
Response<ClassificationPolicy> updatedClassificationPolicyWithoutName = routerAdministrationClient.UpdateClassificationPolicy(classificationPolicyId,
88+
Response updatedClassificationPolicyWithoutName = routerAdministrationClient.UpdateClassificationPolicy(classificationPolicyId,
8989
RequestContent.Create(new { Name = (string?)null }));
9090

91-
Console.WriteLine($"Classification policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(updatedClassificationPolicyWithoutName.Value.Name)}");
91+
Response<ClassificationPolicy> queriedClassificationPolicyWithoutName = routerAdministrationClient.GetClassificationPolicy(classificationPolicyId);
92+
93+
Console.WriteLine($"Classification policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(queriedClassificationPolicyWithoutName.Value.Name)}");
9294
```
9395

9496
## List classification policies

‎sdk/communication/Azure.Communication.JobRouter/samples/ClassificationPolicyCrudAsync.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,12 @@ Console.WriteLine($"Classification policy successfully update with new prioritiz
8585
## Remove from classification policy
8686

8787
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateClassificationPolicyRemoveProp_Async
88-
Response<ClassificationPolicy> updatedClassificationPolicyWithoutName = await routerAdministrationClient.UpdateClassificationPolicyAsync(classificationPolicyId,
88+
Response updatedClassificationPolicyWithoutName = await routerAdministrationClient.UpdateClassificationPolicyAsync(classificationPolicyId,
8989
RequestContent.Create(new { Name = (string?)null }));
9090

91-
Console.WriteLine($"Classification policy successfully update: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(updatedClassificationPolicyWithoutName.Value.Name)}");
91+
Response<ClassificationPolicy> queriedClassificationPolicyWithoutName = await routerAdministrationClient.GetClassificationPolicyAsync(classificationPolicyId);
92+
93+
Console.WriteLine($"Classification policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(queriedClassificationPolicyWithoutName.Value.Name)}");
9294
```
9395

9496
## List classification policies

‎sdk/communication/Azure.Communication.JobRouter/samples/DistributionPolicyCrud.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,12 @@ Console.WriteLine($"Distribution policy successfully update with new distributio
5858
## Remove from distribution policy
5959

6060
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateDistributionPolicyRemoveProp
61-
Response<DistributionPolicy> updatedDistributionPolicyWithoutName = routerAdministrationClient.UpdateDistributionPolicy(distributionPolicyId,
61+
Response updatedDistributionPolicyWithoutName = routerAdministrationClient.UpdateDistributionPolicy(distributionPolicyId,
6262
RequestContent.Create(new { Name = (string?)null }));
6363

64-
Console.WriteLine($"Distribution policy successfully updated: 'Name' has been removed. Status: Status: {string.IsNullOrWhiteSpace(updatedDistributionPolicyWithoutName.Value.Name)}");
64+
Response<DistributionPolicy> queriedDistributionPolicyWithoutName = routerAdministrationClient.GetDistributionPolicy(distributionPolicyId);
65+
66+
Console.WriteLine($"Distribution policy successfully updated: 'Name' has been removed. Status: Status: {string.IsNullOrWhiteSpace(queriedDistributionPolicyWithoutName.Value.Name)}");
6567
```
6668

6769
## List distribution policies

‎sdk/communication/Azure.Communication.JobRouter/samples/DistributionPolicyCrudAsync.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,12 @@ Console.WriteLine($"Distribution policy successfully update with new distributio
5858
## Remove from distribution policy
5959

6060
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateDistributionPolicyRemoveProp_Async
61-
Response<DistributionPolicy> updatedDistributionPolicyWithoutName = await routerAdministrationClient.UpdateDistributionPolicyAsync(distributionPolicyId,
61+
Response updatedDistributionPolicyWithoutName = await routerAdministrationClient.UpdateDistributionPolicyAsync(distributionPolicyId,
6262
RequestContent.Create(new { Name = (string?)null }));
6363

64-
Console.WriteLine($"Distribution policy successfully updated: 'Name' has been removed. Status: Status: {string.IsNullOrWhiteSpace(updatedDistributionPolicyWithoutName.Value.Name)}");
64+
Response<DistributionPolicy> queriedDistributionPolicyWithoutName = await routerAdministrationClient.GetDistributionPolicyAsync(distributionPolicyId);
65+
66+
Console.WriteLine($"Distribution policy successfully updated: 'Name' has been removed. Status: Status: {string.IsNullOrWhiteSpace(queriedDistributionPolicyWithoutName.Value.Name)}");
6567
```
6668

6769
## List distribution policies

‎sdk/communication/Azure.Communication.JobRouter/samples/ExceptionPolicyCrud.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,12 @@ Console.WriteLine($"`EscalateJobOnWaitTimeExceededTrigger2Min` rule has been suc
147147

148148
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateExceptionPolicyRemoveProp
149149
// we are going to remove Name
150-
Response<ExceptionPolicy> updateExceptionPolicyWithoutName = routerClient.UpdateExceptionPolicy(exceptionPolicyId,
150+
Response updateExceptionPolicyWithoutName = routerClient.UpdateExceptionPolicy(exceptionPolicyId,
151151
RequestContent.Create(new { Name = (string?)null }));
152152

153-
Console.WriteLine($"Exception policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(updateExceptionPolicyWithoutName.Value.Name)}");
153+
Response<ExceptionPolicy> queriedExceptionPolicyWithoutName = routerClient.GetExceptionPolicy(exceptionPolicyId);
154+
155+
Console.WriteLine($"Exception policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(queriedExceptionPolicyWithoutName.Value.Name)}");
154156
```
155157

156158
## List exception policies

‎sdk/communication/Azure.Communication.JobRouter/samples/ExceptionPolicyCrudAsync.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,12 @@ Console.WriteLine($"`EscalateJobOnWaitTimeExceededTrigger2Min` rule has been suc
147147

148148
```C# Snippet:Azure_Communication_JobRouter_Tests_Samples_Crud_UpdateExceptionPolicyRemoveProp_Async
149149
// we are going to remove Name
150-
Response<ExceptionPolicy> updateExceptionPolicyWithoutName = await routerClient.UpdateExceptionPolicyAsync(exceptionPolicyId,
150+
Response updateExceptionPolicyWithoutName = await routerClient.UpdateExceptionPolicyAsync(exceptionPolicyId,
151151
RequestContent.Create(new { Name = (string?)null }));
152152

153-
Console.WriteLine($"Exception policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(updateExceptionPolicyWithoutName.Value.Name)}");
153+
Response<ExceptionPolicy> queriedExceptionPolicyWithoutName = await routerClient.GetExceptionPolicyAsync(exceptionPolicyId);
154+
155+
Console.WriteLine($"Exception policy successfully updated: 'Name' has been removed. Status: {string.IsNullOrWhiteSpace(queriedExceptionPolicyWithoutName.Value.Name)}");
154156
```
155157

156158
## List exception policies

0 commit comments

Comments
 (0)