From 96e4f11be60b40facbf5311d226932d1ed051c63 Mon Sep 17 00:00:00 2001
From: Amanda Nguyen <48961492+amnguye@users.noreply.github.com>
Date: Fri, 6 Nov 2020 11:34:39 -0800
Subject: [PATCH] Changing FileSmbProperties default constructor from internal
 to public (#16690)

---
 sdk/storage/Azure.Storage.Files.Shares/CHANGELOG.md          | 1 +
 .../api/Azure.Storage.Files.Shares.netstandard2.0.cs         | 2 +-
 .../src/Models/FileSmbProperties.cs                          | 5 ++++-
 .../Azure.Storage.Files.Shares/tests/FileClientTests.cs      | 3 +--
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/sdk/storage/Azure.Storage.Files.Shares/CHANGELOG.md b/sdk/storage/Azure.Storage.Files.Shares/CHANGELOG.md
index 59cb26bc63460..0c01643267c3b 100644
--- a/sdk/storage/Azure.Storage.Files.Shares/CHANGELOG.md
+++ b/sdk/storage/Azure.Storage.Files.Shares/CHANGELOG.md
@@ -10,6 +10,7 @@
 - Added ability to set Position on streams created with ShareFileClient.OpenRead().
 - Added CanGenerateSasUri property and GenerateSasUri() to ShareFileClient, ShareDirectoryClient and ShareClient.
 - Added CanGenerateSasUri property and GenerateAccountSasUri() to ShareServiceClient.
+- Changed default constructor for FileSmbProperties from internal to public.
 
 ## 12.5.0-preview.1 (2020-09-30)
 - Added support for service version 2020-02-10.
diff --git a/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs b/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs
index 444853e92a2c7..689d0b341319b 100644
--- a/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs
+++ b/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs
@@ -360,7 +360,7 @@ public static partial class FileModelFactory
     }
     public partial class FileSmbProperties
     {
-        internal FileSmbProperties() { }
+        public FileSmbProperties() { }
         public Azure.Storage.Files.Shares.Models.NtfsFileAttributes? FileAttributes { get { throw null; } set { } }
         public System.DateTimeOffset? FileChangedOn { get { throw null; } }
         public System.DateTimeOffset? FileCreatedOn { get { throw null; } set { } }
diff --git a/sdk/storage/Azure.Storage.Files.Shares/src/Models/FileSmbProperties.cs b/sdk/storage/Azure.Storage.Files.Shares/src/Models/FileSmbProperties.cs
index 57b70b51f4ee3..a537d9c4ce487 100644
--- a/sdk/storage/Azure.Storage.Files.Shares/src/Models/FileSmbProperties.cs
+++ b/sdk/storage/Azure.Storage.Files.Shares/src/Models/FileSmbProperties.cs
@@ -52,7 +52,10 @@ public class FileSmbProperties
         /// </summary>
         public string ParentId { get; internal set; }
 
-        internal FileSmbProperties()
+        /// <summary>
+        /// Creates a new FileSmbProperties instance.
+        /// </summary>
+        public FileSmbProperties()
         {
         }
 
diff --git a/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs b/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs
index 33d0fbc5df44b..755e554c4a3d8 100644
--- a/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs
+++ b/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs
@@ -12,14 +12,13 @@
 using Azure.Core.TestFramework;
 using Azure.Storage.Files.Shares.Models;
 using Azure.Storage.Files.Shares.Specialized;
-using Azure.Storage.Files.Shares.Tests;
 using Azure.Storage.Sas;
 using Azure.Storage.Test;
 using Azure.Storage.Test.Shared;
 using BenchmarkDotNet.Toolchains.Roslyn;
 using NUnit.Framework;
 
-namespace Azure.Storage.Files.Shares.Test
+namespace Azure.Storage.Files.Shares.Tests
 {
     public class FileClientTests : FileTestBase
     {