Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Schema Registry Readme and Samples Issue #17929

Closed
v-jiaodi opened this issue Sep 29, 2021 · 3 comments
Closed

Azure Schema Registry Readme and Samples Issue #17929

v-jiaodi opened this issue Sep 29, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Schema Registry test-manual-pass

Comments

@v-jiaodi
Copy link
Member

Section link1,link2,link3,link4,link5:

image
image
image

Reason:
Parameter name and method name reference error

Suggestion:
1.Update groupName to group
2.Add ,
3.Update format to serializationType
4.Update definition to content
5.Update getSchemaProperties to getSchemaId
6.Update getSchema to getSchemaById

@chradek ,@ramya-rao-a and @lilyjma for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Docs Schema Registry labels Sep 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] October milestone Sep 29, 2021
@deyaaeldeen
Copy link
Member

Hey @v-jiaodi the readme has been updated to match the names supported by the version that will be released this month.

I think I should do such work in a feature branches instead to not cause confusion. I will consider doing this moving forward. I opened #18019 to fix the second issue in your list.

@deyaaeldeen deyaaeldeen added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Oct 4, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

Hi @v-jiaodi. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@v-xuto
Copy link
Member

v-xuto commented Oct 8, 2021

Close this issue, due to PR (#18019) merged.

@v-xuto v-xuto closed this as completed Oct 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Schema Registry test-manual-pass
Projects
None yet
Development

No branches or pull requests

4 participants