-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core AMQP] move common duplicate internal code in SB & EH back to core-amqp #12397
Comments
I think keeping core-amqp as a package is a better plan than treating it like keyvault-common. I see a couple issues with the keyvault-common approach:
|
Beyond the issues that Chris mentions (size duplication and the difficulty of doing browser/node versions), there are some dev quality of life things (that can perhaps be mitigated by proper configuration):
|
Based on the above discussions, we want to continue with having core-amqp as the place to share code. |
Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
There is quite a bit of common code between Service Bus and Event Hubs which were previously housed in and exported from
@azure/core-amqp
. But most of these are internal details and need not be exposed to user allowing us to change/break the apis.As part of v2 for
@azure/core-amqp
, we are moving such code to Service Bus and Event Hubs packages. This issue is to have a folder to house these changes in a single place and then referenced by Service Bus and Event Hubs packages just like how we have the keyvault-common folder.Below are the candidates to live in this folder
Update as of 15th July 2021:
Based on the below discussions, we want to continue with having core-amqp as the place to share code.
Keeping this issue open to move the duplicate code i.e. the candidates mentioned above back to core-amqp
Code pointers:
@azure/service-bus
can be found insdk/servicebus/service-bus
@azure/event-hubs
can be found insdk/eventhubs/event-hubs
@azure/core-amqp
can be fond insdk/core-core-amqp
The text was updated successfully, but these errors were encountered: