NITs

Author: FabianMeiswinkel

sdk/cosmos/azure-cosmos-encryption/src/test/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncClientTest.java

@@ -97,7 +97,7 @@ public void afterClassSetupLeakDetection() {
             }
 
             if (sb.length() > 0) {
-                String msg = "\"COSMOS CLIENT LEAKS detected in test class: "
+                String msg = "COSMOS CLIENT LEAKS detected in test class: "
                     + this.getClass().getCanonicalName()
                     + "\n\n"
                     + sb;

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosAsyncClientTest.java

@@ -97,7 +97,7 @@ public void afterClassSetupLeakDetection() {
             }
 
             if (sb.length() > 0) {
-                String msg = "\"COSMOS CLIENT LEAKS detected in test class: "
+                String msg = "COSMOS CLIENT LEAKS detected in test class: "
                     + this.getClass().getCanonicalName()
                     + "\n\n"
                     + sb;
@@ -113,7 +113,7 @@ public void afterClassSetupLeakDetection() {
                     sb.append(leak).append("\n");
                 }
 
-                String msg = "\"NETTY LEAKS detected in test class: "
+                String msg = "NETTY LEAKS detected in test class: "
                     + this.getClass().getCanonicalName()
                     + sb;
 

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/DocumentClientTest.java

@@ -91,7 +91,7 @@ public void afterClassSetupLeakDetection() {
             }
 
             if (sb.length() > 0) {
-                String msg = "\"COSMOS CLIENT LEAKS detected in test class: "
+                String msg = "COSMOS CLIENT LEAKS detected in test class: "
                     + this.getClass().getCanonicalName()
                     + "\n\n"
                     + sb;
@@ -107,7 +107,7 @@ public void afterClassSetupLeakDetection() {
                     sb.append(leak).append("\n");
                 }
 
-                String msg = "\"NETTY LEAKS detected in test class: "
+                String msg = "NETTY LEAKS detected in test class: "
                     + this.getClass().getCanonicalName()
                     + sb;
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java

@@ -374,7 +374,8 @@ public class Configs {
 
     public static final String DEFAULT_OTEL_SPAN_ATTRIBUTE_NAMING_SCHEME = "All";
 
-    private static final boolean DEFAULT_CLIENT_LEAK_DETECTION_ENABLED = true; // TODO @fabianm - revert before merging - just cheaper to enable than making test config changes
+    // TODO @fabianm - Make test changes to enable leak detection from CI pipeline tests
+    private static final boolean DEFAULT_CLIENT_LEAK_DETECTION_ENABLED = false;
     private static final String CLIENT_LEAK_DETECTION_ENABLED = "COSMOS.CLIENT_LEAK_DETECTION_ENABLED";
 
     public static int getCPUCnt() {

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

@@ -203,7 +203,7 @@ public class RxDocumentClientImpl implements AsyncDocumentClient, IAuthorization
 
     private static final Object staticLock = new Object();
 
-    // A map containing the clientId with the callstack form where the Client was initialized.
+    // A map containing the clientId with the callstack from where the Client was initialized.
     // this can help to identify where clients leak.
     // The leak detection via System property "COSMOS.CLIENT_LEAK_DETECTION_ENABLED" is disabled by
     // default - CI pipeline tests will enable it.