Add ADU capabilities to feature branch #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaavva
reviewed
Sep 15, 2022
| #define SAS_TOKEN_DURATION_IN_MINUTES 60 | ||
| #define UNIX_TIME_NOV_13_2017 1510592825 | ||
|
|
||
| #define PST_TIME_ZONE -8 |
There was a problem hiding this comment.
Does this make the sample locked to PST?
There was a problem hiding this comment.
You know that's an interesting question. I know I'm running mine not in Pacific but we should make a note of this.
vaavva
reviewed
Sep 15, 2022
vaavva
reviewed
Sep 15, 2022
vaavva
reviewed
Sep 15, 2022
vaavva
reviewed
Sep 15, 2022
vaavva
reviewed
Sep 15, 2022
danewalton
commented
Sep 15, 2022
vaavva
reviewed
Sep 26, 2022
vaavva
reviewed
Sep 26, 2022
vaavva
reviewed
Sep 26, 2022
vaavva
reviewed
Sep 26, 2022
wduraes
approved these changes
Oct 25, 2022
|
@danieljurek can you help with the cla check. Unsure why this is blocked since the license/cla passed as part of the checks |
vaavva
reviewed
Oct 25, 2022
| @@ -71,7 +71,7 @@ _The following was run on Windows 11 and Ubuntu Desktop 20.04 environments, with | |||
|
|
|||
| - On the Arduino IDE, go to menu `Sketch`, `Include Library`, `Manage Libraries...`. | |||
| - Search for and install `azure-sdk-for-c`. | |||
| - TODO: Make sure to install the `<INSERT BETA VERSION>` to use the preview version of the Embedded C SDK. | |||
| - **Make sure to install the `1.1.0-beta.1` to use the preview version of the Embedded C SDK.** | |||
There was a problem hiding this comment.
I don't see this version, do you mean 1.0.0-beta-1?
There was a problem hiding this comment.
https://github.com/Azure/azure-sdk-for-c-arduino/releases/tag/1.1.0-beta.1
The release is here and should hopefully get pulled in the next time the Arduino Library manager updates its index (should do it every hour).
danewalton
added a commit
that referenced
this pull request
Oct 26, 2022
danewalton
added a commit
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.