-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9670
Conversation
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1027 - DefaultValueChanged |
The new version has a different default value than the previous one. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3648:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3448:9 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "ReservationTransaction": { | ||
| "description": "Reservation transaction resource.", | ||
| "type": "object", | ||
| "discriminator": "kind", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"discriminator": "kind", [](start = 6, length = 24)
these kinds of changes to an existing api-version will break clients. Please introduce a new api-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API only supports legacy accounts currently. The only change for the existing callers is an additional "kind" property.
With this change, callers with modern accounts will be able to use the API.
Adding a new api-Version is an expensive change on our side, which we are planning to do some time later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when a user with a modern account tries to use this API with existing clients that don't support this new contract?
...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json
Outdated
Show resolved
Hide resolved
...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json
Outdated
Show resolved
Hide resolved
pilor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
| "api-version": "2019-10-01", | ||
| "billingAccountId": "123456", | ||
| "$filter": "properties/eventDate ge 2019-09-09 AND properties/eventDate le 2019-09-10" | ||
| "api-version": "2020-01-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you update the api-version in example file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a leftover from my previous attempt of adding a new api-Version. Updated it.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @sri- you have a breaking change in this spec https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json#L3331 . Seems like it's a mistake in old spec? The default value looks like description |
Yeah it is a bug in the old spec. |
|
@akning-ms Please help to merge this PR with breaking change that fix the bug. |
…on stable/2019-10-01 (Azure#9670) * Adding GTM reservation transactions API * update * updating examples * updating examples * adding scope parameter * updating examples * prettifying * updates * Adding missing property in examples * updates * prettify examples * Removing LegacyReservationTransactionsListResult * Removing updates to ReservationTransactions at BillingAccount scope * updates * updating example * removing extra property
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.