Skip to content

Conversation

@sri-
Copy link
Contributor

@sri- sri- commented Jun 2, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 2, 2020

[Staging] Swagger Validation Report

~[Staging] BreakingChange: 1 Errors, 0 Warnings [Detail][Expand Details]
Rule Message
1027 - DefaultValueChanged The new version has a different default value than the previous one.
New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3648:9
Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3448:9
Posted by Swagger Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 2, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 2, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from bfa4f70 with merge commit 4314c1c. SDK Automation 13.0.17.20200605.3
  • ️✔️sdk/consumption/mgmt-v2017_04_24_preview [View full logs]  [Release SDK Changes]
  • ️✔️sdk/consumption/mgmt-v2017_11_30 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/consumption/mgmt-v2018_01_31 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_01_31/src/main/java/com/microsoft/azure/management/consumption/v2018_01_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
      [mvn]   symbol: variable inner
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_01_31/src/main/java/com/microsoft/azure/management/consumption/v2018_01_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
      [mvn] [ERROR]   symbol: variable inner
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/consumption/mgmt-v2018_03_31 [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
        [mvn]   symbol: variable inner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsImpl.java:[21,143] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsModelImpl.java:[18,110] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
        [mvn] [ERROR]   symbol: variable inner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsImpl.java:[21,143] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsModelImpl.java:[18,110] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ️✔️sdk/consumption/mgmt-v2018_05_31 [View full logs]  [Release SDK Changes]
      • ⚠️sdk/consumption/mgmt-v2018_06_30 [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/BudgetsImpl.java:[154,21] cannot find symbol
          [mvn]   symbol: variable inner
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/BudgetsImpl.java:[154,21] cannot find symbol
          [mvn] [ERROR]   symbol: variable inner
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        • ⚠️sdk/consumption/mgmt-v2018_08_31 [View full logs]  [Release SDK Changes]
            [mvn] [ERROR] COMPILATION ERROR : 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
            [mvn]   symbol: variable inner
            [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
            [mvn] [ERROR]   symbol: variable inner
            [mvn] [ERROR] -> [Help 1]
            [mvn] [ERROR] 
            [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
            [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
            [mvn] [ERROR] 
            [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
            [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          • ⚠️sdk/consumption/mgmt-v2018_10_01 [View full logs]  [Release SDK Changes]
              [mvn] [ERROR] COMPILATION ERROR : 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/BudgetsImpl.java:[154,21] cannot find symbol
              [mvn]   symbol: variable inner
              [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/BudgetsImpl.java:[154,21] cannot find symbol
              [mvn] [ERROR]   symbol: variable inner
              [mvn] [ERROR] -> [Help 1]
              [mvn] [ERROR] 
              [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
              [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
              [mvn] [ERROR] 
              [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
              [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
            • ⚠️sdk/consumption/mgmt-v2019_01_01 [View full logs]  [Release SDK Changes]
                [mvn] [ERROR] COMPILATION ERROR : 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
                [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
                [mvn] [ERROR] -> [Help 1]
                [mvn] [ERROR] 
                [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                [mvn] [ERROR] 
                [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 2, 2020

              azure-sdk-for-net - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 2, 2020

              azure-sdk-for-js - Release

              failed [Logs] [Expand Details]
              • Generate from bfa4f70 with merge commit 4314c1c. SDK Automation 13.0.17.20200605.3
              • @azure/arm-consumption [View full logs]  [Release SDK Changes]
                  [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                  [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
                  [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
                  [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
                  [npmPack] npm ERR! code ELIFECYCLE
                  [npmPack] npm ERR! errno 2
                  [npmPack] npm ERR! @azure/arm-consumption@6.3.0 build: `tsc && rollup -c rollup.config.js && npm run minify`
                  [npmPack] npm ERR! Exit status 2
                  [npmPack] npm ERR! 
                  [npmPack] npm ERR! Failed at the @azure/arm-consumption@6.3.0 build script.
                  [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
                  [npmPack] 
                  [npmPack] npm ERR! A complete log of this run can be found in:
                  [npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-06-12T10_36_05_222Z-debug.log
                  [npmPack] npm ERR! code ELIFECYCLE
                  [npmPack] npm ERR! errno 2
                  [npmPack] npm ERR! @azure/arm-consumption@6.3.0 prepack: `npm install && npm run build`
                  [npmPack] npm ERR! Exit status 2
                  [npmPack] npm ERR! 
                  [npmPack] npm ERR! Failed at the @azure/arm-consumption@6.3.0 prepack script.
                  [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
                  [npmPack] 
                  [npmPack] npm ERR! A complete log of this run can be found in:
                  [npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-06-12T10_36_05_238Z-debug.log
                  Failed to create the package @azure/arm-consumption.
                  Error: npm pack npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                  npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
                  npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
                  npm notice created a lockfile as package-lock.json. You should commit this file.
                  npm ERR! code ELIFECYCLE
                  npm ERR! errno 2
                  npm ERR! @azure/arm-consumption@6.3.0 build: `tsc && rollup -c rollup.config.js && npm run minify`
                  npm ERR! Exit status 2
                  npm ERR! 
                  npm ERR! Failed at the @azure/arm-consumption@6.3.0 build script.
                  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
                  

                  npm ERR! A complete log of this run can be found in:
                  npm ERR! /home/sdk/.npm/_logs/2020-06-12T10_36_05_222Z-debug.log
                  npm ERR! code ELIFECYCLE
                  npm ERR! errno 2
                  npm ERR! @azure/arm-consumption@6.3.0 prepack: npm install && npm run build
                  npm ERR! Exit status 2
                  npm ERR!
                  npm ERR! Failed at the @azure/arm-consumption@6.3.0 prepack script.
                  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

                  npm ERR! A complete log of this run can be found in:
                  npm ERR! /home/sdk/.npm/_logs/2020-06-12T10_36_05_238Z-debug.log
                  , {}

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Jun 2, 2020

                azure-sdk-for-python - Release

                - Breaking Change detected in SDK

                ⚠️ warning [Logs] [Expand Details]
                • ⚠️ Generate from bfa4f70 with merge commit 4314c1c. SDK Automation 13.0.17.20200605.3
                • ⚠️azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
                  [build_conf] INFO:packaging_tools:Building template azure-mgmt-consumption
                  [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
                  [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
                  [build_conf] INFO:packaging_tools:Template done azure-mgmt-consumption
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                  [build_package]   warnings.warn(msg)
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                  [build_package]   warnings.warn(msg)
                  [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                  [ChangeLog] Size of delta 63.364% size of original (original: 72355 chars, delta: 45847 chars)
                  [ChangeLog] **Features**
                  [ChangeLog] 
                  [ChangeLog]   - Model ReservationDetail has a new parameter kind
                  [ChangeLog]   - Model ReservationDetail has a new parameter instance_flexibility_group
                  [ChangeLog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
                  [ChangeLog]   - Model Notification has a new parameter threshold_type
                  [ChangeLog]   - Model Budget has a new parameter filter
                  [ChangeLog]   - Model ReservationSummary has a new parameter kind
                  [ChangeLog]   - Model ReservationSummary has a new parameter used_quantity
                  [ChangeLog]   - Model ReservationSummary has a new parameter purchased_quantity
                  [ChangeLog]   - Model ReservationSummary has a new parameter utilized_percentage
                  [ChangeLog]   - Model ReservationSummary has a new parameter remaining_quantity
                  [ChangeLog]   - Model ReservationSummary has a new parameter total_reserved_quantity
                  [ChangeLog]   - Added operation ReservationsDetailsOperations.list
                  [ChangeLog]   - Added operation ReservationRecommendationsOperations.list
                  [ChangeLog]   - Added operation ReservationsSummariesOperations.list
                  [ChangeLog]   - Added operation ChargesOperations.list
                  [ChangeLog]   - Added operation group ReservationRecommendationDetailsOperations
                  [ChangeLog]   - Added operation group EventsOperations
                  [ChangeLog]   - Added operation group LotsOperations
                  [ChangeLog]   - Added operation group CreditsOperations
                  [ChangeLog]   - Added operation group ReservationTransactionsOperations
                  [ChangeLog] 
                  [ChangeLog] **Breaking changes**
                  [ChangeLog] 
                  [ChangeLog]   - Model Budget no longer has parameter filters
                  [ChangeLog]   - Removed operation UsageDetailsOperations.download
                  [ChangeLog]   - Model ChargeSummary has a new signature
                  [ChangeLog]   - Model UsageDetail has a new signature
                  [ChangeLog]   - Model ReservationRecommendation has a new signature
                  [ChangeLog]   - Removed operation ChargesOperations.list_by_scope

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Jun 2, 2020

                Azure CLI Extension Generation - Release

                No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Jun 2, 2020

                Trenton Generation - Release

                No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                @azuresdkci
                Copy link
                Contributor

                Can one of the admins verify this patch?

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                "ReservationTransaction": {
                "description": "Reservation transaction resource.",
                "type": "object",
                "discriminator": "kind",
                Copy link
                Contributor

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                "discriminator": "kind", [](start = 6, length = 24)

                these kinds of changes to an existing api-version will break clients. Please introduce a new api-version

                Copy link
                Contributor Author

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                The API only supports legacy accounts currently. The only change for the existing callers is an additional "kind" property.

                With this change, callers with modern accounts will be able to use the API.

                Adding a new api-Version is an expensive change on our side, which we are planning to do some time later.

                Copy link
                Contributor

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                What happens when a user with a modern account tries to use this API with existing clients that don't support this new contract?

                Copy link
                Contributor

                @pilor pilor left a comment

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                🕐

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Jun 5, 2020

                azure-sdk-for-python-track2 - Release

                No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                "api-version": "2019-10-01",
                "billingAccountId": "123456",
                "$filter": "properties/eventDate ge 2019-09-09 AND properties/eventDate le 2019-09-10"
                "api-version": "2020-01-01",

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                Why do you update the api-version in example file?

                Copy link
                Contributor Author

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                That's a leftover from my previous attempt of adding a new api-Version. Updated it.

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @sri- sri- requested a review from pilor June 9, 2020 01:12
                @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 9, 2020
                @PhoenixHe-NV
                Copy link

                PhoenixHe-NV commented Jun 11, 2020

                Hi @sri- you have a breaking change in this spec https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json#L3331 . Seems like it's a mistake in old spec? The default value looks like description

                @sri-
                Copy link
                Contributor Author

                sri- commented Jun 11, 2020

                Hi @sri- you have a breaking change in this spec https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json#L3331 . Seems like it's a mistake in old spec? The default value looks like description

                Yeah it is a bug in the old spec.

                @PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 12, 2020
                @PhoenixHe-NV
                Copy link

                @akning-ms Please help to merge this PR with breaking change that fix the bug.

                @akning-ms akning-ms merged commit 4314c1c into Azure:master Jun 12, 2020
                00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                …on stable/2019-10-01 (Azure#9670)
                
                * Adding GTM reservation transactions API
                
                * update
                
                * updating examples
                
                * updating examples
                
                * adding scope parameter
                
                * updating examples
                
                * prettifying
                
                * updates
                
                * Adding missing property in examples
                
                * updates
                
                * prettify examples
                
                * Removing LegacyReservationTransactionsListResult
                
                * Removing updates to ReservationTransactions at BillingAccount scope
                
                * updates
                
                * updating example
                
                * removing extra property
                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                Labels

                Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

                Projects

                None yet

                Development

                Successfully merging this pull request may close these issues.

                5 participants