[Linked to PR# 1045] Adding support for encryption key type #8035

HimanshuChhabra · 2019-12-26T22:15:26Z

…ices for table and queue)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ices for table and queue)

azuresdkci · 2019-12-26T22:15:41Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-26T22:15:43Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-26T22:17:43Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1998d0a with merge commit ab39a93. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-storage [Logs] [Release SDK Changes]

azure-arm-storage-12.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 554ms

openapi-sdkautomation · 2019-12-26T22:17:43Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 1998d0a with merge commit ab39a93. SDK Automation 13.0.17.20191226.1
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Release SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[63,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[63,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2019-12-26T22:17:53Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1998d0a with merge commit ab39a93. SDK Automation 13.0.17.20191226.1
️✔️preview/storage/mgmt/2015-05-01-preview [Logs] [Release SDK Changes]
- preview.storage.mgmt.2015-05-01-preview.zip
️✔️preview/storage/mgmt/2018-03-01-preview [Logs] [Release SDK Changes]
- preview.storage.mgmt.2018-03-01-preview.zip
️✔️storage/mgmt/2015-06-15 [Logs] [Release SDK Changes]
- storage.mgmt.2015-06-15.zip
️✔️storage/mgmt/2016-01-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-01-01.zip
️✔️storage/mgmt/2016-05-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-05-01.zip
️✔️storage/mgmt/2016-12-01 [Logs] [Release SDK Changes]
- storage.mgmt.2016-12-01.zip
️✔️storage/mgmt/2017-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2017-06-01.zip
️✔️storage/mgmt/2017-10-01 [Logs] [Release SDK Changes]
- storage.mgmt.2017-10-01.zip
️✔️storage/mgmt/2018-02-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-02-01.zip
️✔️storage/mgmt/2018-07-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-07-01.zip
️✔️storage/mgmt/2018-11-01 [Logs] [Release SDK Changes]
- storage.mgmt.2018-11-01.zip
️✔️storage/mgmt/2019-04-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-04-01.zip
️✔️storage/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2019-12-26T22:17:54Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1998d0a with merge commit ab39a93. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Storage [Logs] [Release SDK Changes]

openapi-sdkautomation · 2019-12-26T22:17:54Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 1998d0a with merge commit ab39a93. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-storage [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

erich-wang · 2019-12-27T03:32:12Z

@HimanshuChhabra, could you let us know why do you add Do Not Merge in title?

HimanshuChhabra · 2019-12-27T19:24:19Z

@HimanshuChhabra, could you let us know why do you add Do Not Merge in title?

@erich-wang the server side is currently deploying across regions and thus we want to pause the merge for now.

HimanshuChhabra · 2019-12-30T10:12:19Z

@erich-wang This PR was already approved in private repo# 1045

anthony-c-martin · 2020-01-06T23:26:04Z

@erich-wang This PR was already approved in private repo# 1045

Signed off for ARM as this has already been signed off in private

erich-wang · 2020-01-07T05:03:51Z

@HimanshuChhabra, please remove Do Not Merge from title when this is PR is ready for merge.

HimanshuChhabra · 2020-01-07T06:02:24Z

@HimanshuChhabra, please remove Do Not Merge from title when this is PR is ready for merge.

Yes, I will. Thank you

azure-pipelines · 2020-01-09T04:58:43Z

Azure Pipelines successfully started running 1 pipeline(s).

HimanshuChhabra · 2020-01-09T05:00:23Z

@erich-wang\ @anthony-c-martin Kindly Initiate Merge for this PR. Thank you.

Adding all files, examples (removed the readonly from encryption serv…

1998d0a

…ices for table and queue)

azuresdkci assigned erich-wang Dec 26, 2019

azuresdkci requested a review from erich-wang December 26, 2019 22:16

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 27, 2019

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2020

erich-wang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 7, 2020

HimanshuChhabra changed the title ~~[Do Not Merge] [Linked to PR# 1045] Adding support for encryption key type~~ [Linked to PR# 1045] Adding support for encryption key type Jan 9, 2020

blueww mentioned this pull request Jan 9, 2020

[Storage] support Queue/Table Encyrtpion Keytype Azure/azure-sdk-for-net#9401

Merged

blueww removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 9, 2020

erich-wang approved these changes Jan 9, 2020

View reviewed changes

erich-wang merged commit ab39a93 into Azure:master Jan 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Linked to PR# 1045] Adding support for encryption key type #8035

[Linked to PR# 1045] Adding support for encryption key type #8035

HimanshuChhabra commented Dec 26, 2019

azuresdkci commented Dec 26, 2019

azure-pipelines bot commented Dec 26, 2019

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

erich-wang commented Dec 27, 2019

HimanshuChhabra commented Dec 27, 2019

HimanshuChhabra commented Dec 30, 2019

anthony-c-martin commented Jan 6, 2020

erich-wang commented Jan 7, 2020

HimanshuChhabra commented Jan 7, 2020

azure-pipelines bot commented Jan 9, 2020

HimanshuChhabra commented Jan 9, 2020 •

edited

Loading

[Linked to PR# 1045] Adding support for encryption key type #8035

[Linked to PR# 1045] Adding support for encryption key type #8035

Conversation

HimanshuChhabra commented Dec 26, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Dec 26, 2019

azure-pipelines bot commented Dec 26, 2019

openapi-sdkautomation bot commented Dec 26, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 26, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 26, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 26, 2019 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Dec 26, 2019 • edited Loading

azure-sdk-for-python - Release

erich-wang commented Dec 27, 2019

HimanshuChhabra commented Dec 27, 2019

HimanshuChhabra commented Dec 30, 2019

anthony-c-martin commented Jan 6, 2020

erich-wang commented Jan 7, 2020

HimanshuChhabra commented Jan 7, 2020

azure-pipelines bot commented Jan 9, 2020

HimanshuChhabra commented Jan 9, 2020 • edited Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 26, 2019 •

edited

Loading

HimanshuChhabra commented Jan 9, 2020 •

edited

Loading