Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java sdk restructure #7785

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Java sdk restructure #7785

merged 6 commits into from
Nov 21, 2019

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Nov 15, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Issue Azure/azure-sdk-for-java#5682
PR in azure-sdk-for-java for restructing is merged Azure/azure-sdk-for-java#6333
A follow-up PR is pending Azure/azure-sdk-for-java#6423

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • datacatalog/resource-manager
  • datafactory/resource-manager
  • datamigration/resource-manager
  • storageimportexport/resource-manager
  • containerinstance/resource-manager
  • machinelearningcompute/resource-manager
  • mariadb/resource-manager
  • iotspaces/resource-manager
  • imagebuilder/resource-manager
  • resourcegraph/resource-manager
  • machinelearningexperimentation/resource-manager
  • iothub/resource-manager
  • appconfiguration/resource-manager
  • maintenance/resource-manager
  • managementgroups/resource-manager
  • sql/resource-manager
  • labservices/resource-manager
  • msi/resource-manager
  • containerregistry/resource-manager
  • hdinsight/resource-manager
  • datalake-store/resource-manager
  • storsimple8000series/resource-manager
  • EnterpriseKnowledgeGraph/resource-manager
  • authorization/resource-manager
  • azure-kusto/resource-manager
  • policyinsights/resource-manager
  • workloadmonitor/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • deviceprovisioningservices/resource-manager
  • commerce/resource-manager
  • operationsmanagement/resource-manager
  • servicefabric/resource-manager
  • deploymentmanager/resource-manager
  • visualstudio/resource-manager
  • applicationinsights/resource-manager
  • machinelearning/resource-manager
  • mediaservices/resource-manager
  • dns/resource-manager
  • healthcareapis/resource-manager
  • consumption/resource-manager
  • netapp/resource-manager
  • batch/resource-manager
  • eventgrid/resource-manager
  • cosmos-db/resource-manager
  • advisor/resource-manager
  • streamanalytics/resource-manager
  • datalake-analytics/resource-manager
  • addons/resource-manager
  • cognitiveservices/resource-manager
  • compute/resource-manager
  • iotcentral/resource-manager
  • servicefabricmesh/resource-manager
  • cost-management/resource-manager
  • notificationhubs/resource-manager
  • postgresql/resource-manager
  • migrateprojects/resource-manager
  • resourcehealth/resource-manager
  • operationalinsights/resource-manager
  • recoveryservices/resource-manager
  • devtestlabs/resource-manager
  • service-map/resource-manager
  • hybridcompute/resource-manager
  • azurestack/resource-manager
  • alertsmanagement/resource-manager
  • peering/resource-manager
  • redis/resource-manager
  • machinelearningservices/resource-manager
  • adhybridhealthservice/resource-manager
  • analysisservices/resource-manager
  • storagecache/resource-manager
  • hanaonazure/resource-manager
  • managementpartner/resource-manager
  • sqlvirtualmachine/resource-manager
  • timeseriesinsights/resource-manager
  • batchai/resource-manager
  • customer-insights/resource-manager
  • keyvault/resource-manager
  • logic/resource-manager
  • web/resource-manager
  • vmwarecloudsimple/resource-manager
  • mysql/resource-manager
  • containerservice/resource-manager
  • maps/resource-manager
  • subscription/resource-manager
  • eventhub/resource-manager
  • automation/resource-manager
  • databoxedge/resource-manager
  • appplatform/resource-manager
  • resources/resource-manager
  • databricks/resource-manager
  • signalr/resource-manager
  • powerbiembedded/resource-manager
  • devspaces/resource-manager
  • recoveryservicesbackup/resource-manager
  • migrate/resource-manager
  • marketplaceordering/resource-manager
  • search/resource-manager
  • botservice/resource-manager
  • storage/resource-manager
  • windowsiot/resource-manager
  • databox/resource-manager
  • privatedns/resource-manager
  • apimanagement/resource-manager
  • servicebus/resource-manager
  • powerbidedicated/resource-manager
  • billing/resource-manager
  • scheduler/resource-manager
  • relay/resource-manager
  • storagesync/resource-manager
  • network/resource-manager
  • domainservices/resource-manager

@AutorestCI
Copy link

AutorestCI commented Nov 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • databricks/resource-manager
  • dns/resource-manager
  • compute/resource-manager
  • databox/resource-manager
  • servicefabric/resource-manager
  • botservice/resource-manager
  • subscription/resource-manager
  • network/resource-manager
  • logic/resource-manager
  • datalake-store/resource-manager
  • containerinstance/resource-manager
  • addons/resource-manager
  • applicationinsights/resource-manager
  • automation/resource-manager
  • visualstudio/resource-manager
  • batchai/resource-manager
  • recoveryservicesbackup/resource-manager
  • authorization/resource-manager
  • scheduler/resource-manager
  • hdinsight/resource-manager
  • containerservice/resource-manager
  • eventhub/resource-manager
  • cognitiveservices/resource-manager
  • streamanalytics/resource-manager
  • iotspaces/resource-manager
  • iotcentral/resource-manager
  • devtestlabs/resource-manager
  • iothub/resource-manager
  • mediaservices/resource-manager
  • policyinsights/resource-manager
  • redis/resource-manager
  • keyvault/resource-manager
  • storsimple8000series/resource-manager
  • eventgrid/resource-manager
  • windowsiot/resource-manager
  • recoveryservices/resource-manager
  • migrate/resource-manager
  • notificationhubs/resource-manager
  • workloadmonitor/resource-manager
  • search/resource-manager
  • sqlvirtualmachine/resource-manager
  • managementgroups/resource-manager
  • managementpartner/resource-manager
  • machinelearningexperimentation/resource-manager
  • deploymentmanager/resource-manager
  • msi/resource-manager
  • peering/resource-manager
  • postgresql/resource-manager
  • alertsmanagement/resource-manager
  • hybridcompute/resource-manager
  • datalake-analytics/resource-manager
  • storagecache/resource-manager
  • datamigration/resource-manager
  • operationalinsights/resource-manager
  • timeseriesinsights/resource-manager
  • healthcareapis/resource-manager
  • machinelearning/resource-manager
  • cosmos-db/resource-manager
  • relay/resource-manager
  • advisor/resource-manager
  • marketplaceordering/resource-manager
  • apimanagement/resource-manager
  • deviceprovisioningservices/resource-manager
  • commerce/resource-manager
  • databoxedge/resource-manager
  • datacatalog/resource-manager
  • web/resource-manager
  • storage/resource-manager
  • datafactory/resource-manager
  • migrateprojects/resource-manager
  • azurestack/resource-manager
  • mariadb/resource-manager
  • sql/resource-manager
  • service-map/resource-manager
  • maps/resource-manager
  • labservices/resource-manager
  • storagesync/resource-manager
  • domainservices/resource-manager
  • recoveryservicessiterecovery/resource-manager
  • appconfiguration/resource-manager
  • containerregistry/resource-manager
  • powerbidedicated/resource-manager
  • servicebus/resource-manager
  • servicefabricmesh/resource-manager
  • mysql/resource-manager
  • adhybridhealthservice/resource-manager
  • resourcehealth/resource-manager
  • customer-insights/resource-manager
  • imagebuilder/resource-manager
  • cost-management/resource-manager
  • batch/resource-manager
  • signalr/resource-manager
  • azure-kusto/resource-manager
  • maintenance/resource-manager
  • hanaonazure/resource-manager
  • EnterpriseKnowledgeGraph/resource-manager
  • storageimportexport/resource-manager
  • powerbiembedded/resource-manager
  • appplatform/resource-manager
  • privatedns/resource-manager
  • netapp/resource-manager
  • consumption/resource-manager
  • machinelearningservices/resource-manager
  • billing/resource-manager
  • operationsmanagement/resource-manager
  • resourcegraph/resource-manager
  • machinelearningcompute/resource-manager
  • analysisservices/resource-manager
  • resources/resource-manager
  • vmwarecloudsimple/resource-manager
  • devspaces/resource-manager

@weidongxu-microsoft weidongxu-microsoft added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 15, 2019
@weidongxu-microsoft
Copy link
Member Author

Azure/azure-sdk-for-java#5682

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@brjohnstmsft
Copy link
Member

@weidongxu-microsoft Please request reviews from @miwelsh for Azure Cognitive Search management SDK PRs.

@brjohnstmsft brjohnstmsft removed their request for review November 15, 2019 19:01
@weidongxu-microsoft weidongxu-microsoft changed the title [DO NOT MERGE] Java sdk restructure Java sdk restructure Nov 20, 2019
@weidongxu-microsoft weidongxu-microsoft removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 20, 2019
@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Nov 21, 2019 •
edited
Loading

@yungezz Hello Catherine,

Could we force merge this PR? I tried a few time, but SDK build will always timeout, since there is too many README.md file involved.

This PR basically only rename the java output folder in README.md files, to match current mgmt SDK folder pattern.

Sample here. azure-sdk-for-jave already finished mgmt sdk folder restructuring.
https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/keyvault
Previously it is 'keyvault/resource-manager/v2016_10_01', now moved to 'sdk/keyvault/mgmt-v2016_10_01'.

Background: Peter requested that all mgmt SDK put under 'sdk/{service_name}'.
Issue is this.

@yungezz yungezz merged commit e0996d4 into Azure:master Nov 21, 2019
@weidongxu-microsoft weidongxu-microsoft deleted the java-sdk-restructure branch November 22, 2019 01:51
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@weidongxu-microsoft @AnuTalluri
Java sdk restructure (Azure#7785)
a29f1c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atpham256 atpham256 Awaiting requested review from atpham256 atpham256 is a code owner

@BrianBlum BrianBlum Awaiting requested review from BrianBlum

@hyonholee hyonholee Awaiting requested review from hyonholee

@jaredmoo jaredmoo Awaiting requested review from jaredmoo

@kalyanaj kalyanaj Awaiting requested review from kalyanaj

@matthchr matthchr Awaiting requested review from matthchr matthchr is a code owner

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@naveedaz naveedaz Awaiting requested review from naveedaz naveedaz is a code owner

@anton-evseev anton-evseev Awaiting requested review from anton-evseev

@samkreter samkreter Awaiting requested review from samkreter

@solankisamir solankisamir Awaiting requested review from solankisamir solankisamir is a code owner

@stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

@zikalino zikalino Awaiting requested review from zikalino

@miwelsh miwelsh Awaiting requested review from miwelsh

@schaabs schaabs Awaiting requested review from schaabs

Assignees

@zikalino zikalino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@weidongxu-microsoft @AutorestCI @azuresdkci @brjohnstmsft @zikalino @yungezz