Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription scope to assessment metadata API #6445

Merged
merged 15 commits into from
Jul 11, 2019
Merged

Add subscription scope to assessment metadata API #6445

merged 15 commits into from
Jul 11, 2019

Conversation

tarosler
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 25, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from d5d23f1)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5709

@azuresdkci azuresdkci requested a review from yungezz June 25, 2019 16:23
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5176

@tarosler
Copy link
Contributor Author

the assessmentMetadata.json file already reviewed and approved here. This PR is adding two new paths (subscription scope) to the file.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2019
@chlahav chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 27, 2019
@chlahav chlahav self-requested a review June 27, 2019 08:40
This was referenced Jul 1, 2019
Closed
Closed
@tarosler
Copy link
Contributor Author

tarosler commented Jul 1, 2019

@yungezz fixed all comments. please review once again.

Thanks,
Tal

@sanjaiganesh sanjaiganesh added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewMeetingRequired and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 5, 2019
@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 11, 2019
ryansbenson
ryansbenson approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@yungezz yungezz merged commit b4e0f28 into Azure:master Jul 11, 2019
yungezz added a commit that referenced this pull request Jul 12, 2019
@yungezz
Revert "Add subscription scope to assessment metadata API (#6445)"
0fb583a 
This reverts commit b4e0f28.
@yungezz yungezz mentioned this pull request Jul 12, 2019
Merged
sergey-shandar pushed a commit that referenced this pull request Jul 12, 2019
@yungezz @sergey-shandar
Revert "Add subscription scope to assessment metadata API (#6445)" (#…
070fa08 
…6609)

This reverts commit b4e0f28.
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@tarosler @celikcigdem
Add subscription scope to assessment metadata API (Azure#6445)
ec01d13
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@yungezz @celikcigdem
Revert "Add subscription scope to assessment metadata API (Azure#6445)…
fc26f81 
…" (Azure#6609)

This reverts commit b4e0f28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@yungezz yungezz yungezz approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

@chlahav chlahav Awaiting requested review from chlahav

Assignees

@yungezz yungezz

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tarosler @AutorestCI @azuresdkci @sanjaiganesh @yungezz @ryansbenson @chlahav