Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personalizer : only use rank, reward and activate apis #5835

Merged
merged 2 commits into from
May 2, 2019

Conversation

dwaijam
Copy link
Contributor

@dwaijam dwaijam commented May 2, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@AutorestCI
Copy link

AutorestCI commented May 2, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented May 2, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 2, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented May 2, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 2, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5835'
REST Spec PR Author 'dwaijam'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6042
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@350042c

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwaijam I see you are deleting your API surface area, is this because you are trying to go out right now will limited set of API and no existing APIs are out their that will have any impact.
Once you confirm, I can merge this PR.

@dwaijam
Copy link
Contributor Author

dwaijam commented May 2, 2019

@dwaijam I see you are deleting your API surface area, is this because you are trying to go out right now will limited set of API and no existing APIs are out their that will have any impact.
Once you confirm, I can merge this PR.
Yes I confirm the above. Our current clients are not using the deleted APIs and hence no one will be impacted

@shahabhijeet shahabhijeet merged commit 47d725e into Azure:master May 2, 2019
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* base version

* PlayerAccountPool and Title

* api-version

* debug examples

* changes for Segments Swagger added

* changes to swagger

* Update readme.md

* changes to swagger

* swagger changes as per cadl generated

* changes to swagger

* changes

* Prettier formatting

* changes

* changes

* changes

* changes

* example model validation check

* example model validation check

* example model validation check

* example model validation check

* example model validation check

* changes to swagger

* trying prettier fix

* changes

* fixing Prettier problems

* Update readme.md

* changes to fix problems reported by Prettier

* Update readme.md

* removed unused ref files in examples folder

* add title MSI and fix patch contract (#5729)

* add title MSI and fix patch contract

* spell check & prettier fix

* fix lint error

* fix prettier issue

* changes as per feedback in review

* Added Swagger changes

* changes as per feedback in review

* changes as per feedback in review

* prettier fix

* changes as per feedback in review

* prettier error fix

* some small testing for resource comment in PR

* changing resource to parameters

* changes to fix x-ms-identifier-failure

* Updates for title settings support (#5792)

* Updates for title settings support

* Run PrettierCheck

* Address minor review comment.

* Update RG name maintain consistency.

* Remove extra new line

* Minor change.

* Revert "Updates for title settings support (#5792)" (#5811)

This reverts commit 9697c9592607817fefb01e962ac1cdb92dd23990.

* Add support for Title Settings (#5812)

* Update Swagger

* Update example files.

* few chhnages as per feedback in PR

* fix examples, remove user assigned identities as it is not supported (#5835)

* fix examples, remove user assigned identities as it is not supported

* remove user assigned identity support from swagger

* change which was missed in my previous commit

* changes as per review in PR

* changing playfabAccountPoolId to playfabPlayerAccountPoolId

* changing playfabAccountPoolId to playFabPlayerAccountPoolId

* changes because of typo in examples in renaming

Co-authored-by: Zainudeen V K <zainu.vk@hotmail.com>
Co-authored-by: Zainudeen V K <zainuvk@github.com>
Co-authored-by: shubgup3 <67748348+shubgup3@users.noreply.github.com>
Co-authored-by: Anshul Verma <88476874+AnshulVermaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants