New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A script to generate multiapi readme files. OAV update. #5097

Merged

sergey-shandar merged 5 commits into master from sergey/multi-script

Feb 6, 2019

Contributor

sergey-shandar commented Jan 26, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          A script to generate multiapi readme files. OAV update.

735a040

openapi-portal-comment bot commented Jan 26, 2019

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

AutorestCI commented Jan 26, 2019 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

sergey-shandar requested a review from vladbarosan

January 26, 2019 00:18

sergey-shandar assigned fearthecowboy

Contributor

azuresdkci commented Jan 26, 2019

Can one of the admins verify this patch?

nschonni reviewed

View reviewed changes

package.json

-                  "z-schema": "^3.24.2"
+                  "typescript": "^3.2.4",
+                  "z-schema": "^3.25.0",
+                  "ts-node": "^8.0.1"

Contributor

nschonni Jan 26, 2019

Think this needs to move up, or the next install will re-order it automatically


          Update package.json

4b47704

Contributor Author

sergey-shandar commented Jan 31, 2019

See also generated readme files https://github.com/Azure/azure-rest-api-specs/pull/5080/files

sergey-shandar assigned veronicagg

sergey-shandar added 3 commits

January 31, 2019 10:28


          Move compiled files to dist

c79d888


          Merge branch 'master' into sergey/multi-script

4d93e43


          Merge branch 'master' into sergey/multi-script

7d3bebf

veronicagg suggested changes

View reviewed changes

Contributor

veronicagg left a comment

Few questions before approving, regarding the output, the readmes just contain the files to pick up for generation and no other settings, so they won't be suitable to replace any of the existing. If they are used for code generation, how are we consuming the other setting from existing readme files?
Also I see that we're picking up all the file paths and putting them together for generation, is that what the muti-api feature will take as input?
Code itself looks good to me.

Contributor Author

sergey-shandar commented Feb 1, 2019 •

edited

Loading

@veronicagg, @fearthecowboy knows the answers but, I suspect, it's on an early stage of development so we cane address these issues after.

veronicagg approved these changes

View reviewed changes

sergey-shandar merged commit 5789f3d into master

sergey-shandar deleted the sergey/multi-script branch

February 6, 2019 00:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet