Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billing Demo: MPG + Suppression #30650

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Billing Demo: MPG + Suppression #30650

wants to merge 5 commits into from

Conversation

wanlwanl
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 19, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR modified the suppressions for Go SDK breaking changes (label: BreakingChange-Go-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR modified the suppressions for JavaScript SDK breaking changes (label: BreakingChange-JavaScript-Sdk-Suppression). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 19, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/billing/armbilling https://apiview.dev/Assemblies/Review/55969e5a751c4bab9b4a484900be0c02?revisionId=fff9d4c99d954453a90c086393749488
JavaScript @azure/arm-billing https://apiview.dev/Assemblies/Review/004c7e6cfe7044f887e4d07d2d67f1f1?revisionId=aec7a54ed9824b7d828b0b8c0fb10f5a
.Net Azure.ResourceManager.Billing https://apiview.dev/Assemblies/Review/52d2c600f79f4cd594165b9ceb426dd8?revisionId=6f4c54c0fbd14a76b2f14cf090bbf935
Swagger Microsoft.Billing https://apiview.dev/Assemblies/Review/89ef32e47c754b7795ef881587a41d9a?revisionId=226c0ed3c39f48009bed650bc6051ef2

@azure-sdk azure-sdk mentioned this pull request Sep 19, 2024
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Sep 19, 2024
@wanlwanl wanlwanl added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep labels Sep 19, 2024
This was referenced Sep 19, 2024
Draft
Draft
Draft
@wanlwanl wanlwanl added PublishToCustomers Acknowledgement the changes will be published to Azure customers. ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 19, 2024
@azure-sdk azure-sdk mentioned this pull request Sep 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft will be requested when the pull request is marked ready for review wilcobmsft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Billing BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wanlwanl @azure-sdk @AzureRestAPISpecReview @msyyc @albertxavier100