Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: MPG + Suppression File #30624

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Demo: MPG + Suppression File #30624

wants to merge 8 commits into from

Conversation

wanlwanl
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute https://apiview.dev/Assemblies/Review/13fa09201aa545c19d240f82d38c09c9?revisionId=4aa5ee12bb094ff695c16c398485e43c
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=024021cb4a07478faf3dfd8defbdc55e
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=8bc818cae5ae4a08a4576e10b8077f6c
.Net Azure.ResourceManager.Compute https://apiview.dev/Assemblies/Review/7fec998c6beb4201bb99c335d06c70fa?revisionId=7d168deef3604205985a33ed8c0b5ad2
Swagger Microsoft.Compute https://apiview.dev/Assemblies/Review/b32a43d6ad48477b9343d7a921e72411?revisionId=8fc292bffe8f4d529c53e2d1f597278e

@azure-sdk azure-sdk mentioned this pull request Sep 18, 2024
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Sep 18, 2024
@azure-sdk azure-sdk mentioned this pull request Sep 18, 2024
Draft
This was referenced Sep 18, 2024
Draft
Draft
@azure-sdk azure-sdk mentioned this pull request Sep 18, 2024
Draft
@wanlwanl wanlwanl added Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-PrivatePreview https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-Previously https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Sep 19, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed Versioning-Approved-Previously https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-PrivatePreview https://github.com/Azure/azure-sdk-tools/issues/6374 Versioning-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep labels Sep 19, 2024
@wanlwanl wanlwanl added BreakingChange-Python-Sdk-Suppression-Approved BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Go-Sdk-Approved BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk-Suppression-Approved and removed BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk-Suppression-Approved BreakingChange-Python-Sdk-Suppression-Approved BreakingChange-Go-Sdk-Approved labels Sep 19, 2024
@wanlwanl
Revert "remove op"
ab817a6 
This reverts commit 0917ad4.
@wanlwanl
.
8ff5af6
@wanlwanl
change
ccde652
@wanlwanl
Revert "update"
c2620b7 
This reverts commit ae9deb4.
@wanlwanl
Revert "."
6a428f1 
This reverts commit 8ff5af6.
@AzureRestAPISpecReview AzureRestAPISpecReview removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep labels Sep 19, 2024
@azure-sdk azure-sdk mentioned this pull request Sep 19, 2024
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandido Sandido Awaiting requested review from Sandido Sandido will be requested when the pull request is marked ready for review Sandido is a code owner

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms will be requested when the pull request is marked ready for review dkulkarni-ms is a code owner

@haagha haagha Awaiting requested review from haagha haagha will be requested when the pull request is marked ready for review haagha is a code owner

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs will be requested when the pull request is marked ready for review MS-syh2qs is a code owner

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore grizzlytheodore will be requested when the pull request is marked ready for review grizzlytheodore is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Compute PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanlwanl @azure-sdk @AzureRestAPISpecReview