-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workloads SAPVirtualInstance New GA API 2024-09-01 #30292
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
1885dbc
to
642a417
Compare
44fcd24
to
aaf4eec
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
aaf4eec
to
28e9f5e
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
This reverts commit 1475d61.
Known tooling issue. Approved the suppression. |
Fixes #3543 Exclude new workloads version. The new version appears to have renamed some resources which then get included alongside the existing resources but cause name conflicts in some SDKs. - Specs PR: Azure/azure-rest-api-specs#30292 Source of breaking changes in the `security` module: - Azure/azure-rest-api-specs#30163
@@ -36,4 +36,12 @@ enum Versions { | |||
@useDependency(Azure.Core.Versions.v1_0_Preview_1) | |||
@armCommonTypesVersion(Azure.ResourceManager.CommonTypes.Versions.v3) | |||
v2023_10_01_preview: "2023-10-01-preview", | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to include operations list in SAPVirtualInstance? If so, we should include relevant files directly in SAPVirtualInstance side. You could ask for help in typespec channel regarding how to share spec in typespec.
This will block our SDK release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MaryGao
Our readme has reference to both SAPVirtualInstance as well as operations.
https://github.com/Azure/azure-rest-api-specs/blob/8ad58020cfafc5ace71d85b31272acf4d6b694d3/specification/workloads/resource-manager/Microsoft.Workloads/SAPVirtualInstance/readme.md?plain=1#L40C3-L42C52
Is readme not used anymore to generate the SDKs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajaygit158 We generated from TypeSpec not from swagger. /cc @josefree
Then we need to include relevant typespec in target client and all languages should be generated from typepsec. could you or @jaskisin work on this change? This is blocking our release.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
**This PR is a copy of https://github.com/Azure/azure-rest-api-specs-pr/pull/18927 from private repo which is merged.
The new version 2024-09-01 introduced in this PR is a copy of earlier preview version 2023-10-01-preview along with conversion to typespec.
No new properties/apis have been introduced.