Workloads SAPVirtualInstance New GA API 2024-09-01 #30292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
jaskisin
force-pushed
the
workloadsapi20240901
branch
from
1885dbc
to
642a417
Compare
This was referenced Aug 22, 2024
This was referenced Aug 22, 2024
Closed
jaskisin
force-pushed
the
workloadsapi20240901
branch
2 times, most recently
from
44fcd24
to
aaf4eec
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jaskisin
force-pushed
the
workloadsapi20240901
branch
from
aaf4eec
to
28e9f5e
Compare
JeffreyRichter
added
the
BreakingChange-Approved-Previously
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
AzureRestAPISpecReview
added
WaitForARMFeedback
dhruvesh
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
tadelesh
added
Approved-SdkBreakingChange-Go
added 2 commits
August 26, 2024 13:16
This reverts commit 1475d61.
jaskisin
changed the title
ajaygit158
approved these changes
Aug 26, 2024
|
Known tooling issue. Approved the suppression. |
jaskisin
added
the
PublishToCustomers
danielrbradley
added a commit
to pulumi/pulumi-azure-native
that referenced
this pull request
Aug 28, 2024
Fixes #3543 Exclude new workloads version. The new version appears to have renamed some resources which then get included alongside the existing resources but cause name conflicts in some SDKs. - Specs PR: Azure/azure-rest-api-specs#30292 Source of breaking changes in the `security` module: - Azure/azure-rest-api-specs#30163
MaryGao
reviewed
Oct 17, 2024
| @@ -36,4 +36,12 @@ enum Versions { | |||
| @useDependency(Azure.Core.Versions.v1_0_Preview_1) | |||
| @armCommonTypesVersion(Azure.ResourceManager.CommonTypes.Versions.v3) | |||
| v2023_10_01_preview: "2023-10-01-preview", | |||
|
|
|||
There was a problem hiding this comment.
Do we want to include operations list in SAPVirtualInstance? If so, we should include relevant files directly in SAPVirtualInstance side. You could ask for help in typespec channel regarding how to share spec in typespec.
This will block our SDK release.
There was a problem hiding this comment.
Hi @MaryGao
Our readme has reference to both SAPVirtualInstance as well as operations.
https://github.com/Azure/azure-rest-api-specs/blob/8ad58020cfafc5ace71d85b31272acf4d6b694d3/specification/workloads/resource-manager/Microsoft.Workloads/SAPVirtualInstance/readme.md?plain=1#L40C3-L42C52
Is readme not used anymore to generate the SDKs ?
There was a problem hiding this comment.
@ajaygit158 We generated from TypeSpec not from swagger. /cc @josefree
Then we need to include relevant typespec in target client and all languages should be generated from typepsec. could you or @jaskisin work on this change? This is blocking our release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
**This PR is a copy of https://github.com/Azure/azure-rest-api-specs-pr/pull/18927 from private repo which is merged.
The new version 2024-09-01 introduced in this PR is a copy of earlier preview version 2023-10-01-preview along with conversion to typespec.
No new properties/apis have been introduced.