-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zman/fix conflicts dev aks fleet 2024 02 02 preview #27815
Merged
allenjzhang
merged 166 commits into
dev-aks-fleet-2024-02-02-preview
from
zman/fix-conflicts-dev-aks-fleet-2024-02-02-preview
Feb 22, 2024
Merged
Zman/fix conflicts dev aks fleet 2024 02 02 preview #27815
allenjzhang
merged 166 commits into
dev-aks-fleet-2024-02-02-preview
from
zman/fix-conflicts-dev-aks-fleet-2024-02-02-preview
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding new version * Typspec versioning * adding in examples * fixing examples * formatting * formatting * updating deprecated operations * formatting fixes * removing breaking changes * modify image upload body and docs * fix example * fixing example * adding Location to 202 responses * tsv formatting changes * removing unnecessary model * commiting changes
* Update readme.python.md * Update readme.python.md
…11 preview (#26576) * Generate new Service for azuredatatransfer * Adds base for updating Microsoft.AzureDataTransfer from version private repo version stable/2023-06-28 to public repo version 2023-10-11-preview * Move Microsoft.AzureDataTransfer to public repo with new api-version * Add openapi-subtype * Fix LintDiff errors * Fix examples validation errors * Add Data flow type * Remove additionalProperties * Rename to performRequest * Update result and code * Remove action endpoint, add listApprovedSchemas and validateSchema endpoints
…ensions/chat/completions (#27271) * auth * restore * vector db * fix examples * fix * matrix * fix cosmosdb * fix pinecone description * generated --------- Co-authored-by: Yuantao Wang <yuantw@microsoft.com>
* tsv node 21 * parameter * package logck
…27295) * Update readme.md: Common/stable/2023-06-01 current: Common/stable/2023-07-01 Updated: Common/stable/2023-06-01 * updated version and added exclude-file * reverted changes from preious commit and changed stable version date. * Changed which data v2 swagger file is being pointed to. * Added '- Microsoft.Maps/Data/preview/1.0/data.json' to the deprecated tag.
* remove job name * Update eng/pipelines/typespec-validation.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * Update eng/tools/typespec-validation/ci.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * Update eng/pipelines/typespec-validation-all.yml Co-authored-by: Mike Harder <mharder@microsoft.com> --------- Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Sushil Upadhyay <supadhyay@microsoft.com>
…n Results (#26777) * add scriptCode, and enums for script * update name for sciptcode * fixed policheck and spelling issue * Add new words to custom-words.txt and update Bengala enum
* Update readme.md: Common/stable/2023-06-01 current: Common/stable/2023-07-01 Updated: Common/stable/2023-06-01 * fixed broken links in Creator.
* fix auth implementation * format * suppress auth warning * clean up after team discussion
…stry service. (#27340) * Update readme.md: Common/stable/2023-06-01 current: Common/stable/2023-07-01 Updated: Common/stable/2023-06-01 * Changed references to the data service to the new data registry service. * Changed full-URL links to be site-relative links. * Added words to the override list in cspell.json and ran Prettier check.
* Adds base for updating Microsoft.EdgeOrder from version preview/2022-05-01-preview to version 2024-02-01 * Updates readme * Updates API version in new specs and examples * Made with changes on top of 2023 preview swagger * saving examples * minor: spelling * replace sub Id with guid * mark provisionig state readonly * fix prov details and site details to correct place in hierarchy * orderItem delete remove 200 code * Minor - fix model validation * add suppression * remove 202 from address delete * mark as sync * remove suppression if not needed * keep address asynch * changes as per review * camelCase * making contact details fields not required * add address classification field * rename state to NotInitiated
* Add snowflake v2 linkedService * fix prettier * update snowflakeV2 linkedService * fix prettier * Add snowflake v2 copysource and dataset * Fix prettier * Add swagger changes for synapse * fix prettier * remove AAD auth * Update synapse linkedService * Fix prettier * snowflakeV2 add service principal auth * remove dfe-string * fix prettier check issue
* miss * chunk size --------- Co-authored-by: Yuantao Wang <yuantw@microsoft.com>
…ew pages. (#27370) * Update readme.md: Common/stable/2023-06-01 current: Common/stable/2023-07-01 Updated: Common/stable/2023-06-01 * moved retirement note so it does not appear is the overview page. Corrected broken links to data and data v2 API. * Added suppression to readme for RESPONSE_SCHEMA_NOT_IN_SPEC. reason: false positive from oav is breaking our example validation. See Azure/oav#1021. * fixed links
* Update readme.md: Common/stable/2023-06-01 current: Common/stable/2023-07-01 Updated: Common/stable/2023-06-01 * Fixed broken links that appear in the REST API docs. * Added suppression RESPONSE_SCHEMA_NOT_IN_SPEC. reason: false positive from oav is breaking our example validation. See Azure/oav#1021. * Added suppression RESPONSE_SCHEMA_NOT_IN_SPEC.
Co-authored-by: Bo Wang <v-bw@microsoft.com>
This was referenced Feb 17, 2024
allenjzhang
merged commit Feb 22, 2024
51d8892
into
dev-aks-fleet-2024-02-02-preview
9 of 28 checks passed
allenjzhang
deleted the
zman/fix-conflicts-dev-aks-fleet-2024-02-02-preview
branch
February 22, 2024 20:00
allenjzhang
pushed a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.