[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-10-01 #26483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able/2023-09-01 to version 2023-10-01
…ers (#26389) * feat: add rest api spec for node public IP IPTags * feat: add rest api spec for ip-based load balancer
* add CapacityReservationGroup into custom-words.txt (#26461) Co-authored-by: tong chen <tonche@microsoft.com> * add lower case capacityreservationgroup (#26475) Co-authored-by: tong chen <tonche@microsoft.com> --------- Co-authored-by: Tong Chen <99183466+tonychen15@users.noreply.github.com> Co-authored-by: tong chen <tonche@microsoft.com>
Co-authored-by: tong chen <tonche@microsoft.com>
FumingZhang
requested review from
msyyc,
palma21,
weinong,
alvinli222,
matthchr and
circy9
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| managedClusters.json | 2023-10-01(5f495af) | 2023-09-01(main) |
| managedClusters.json | 2023-10-01(5f495af) | 2023-09-02-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/agentPools/{agentPoolName}/machines' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L1351:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/agentPools/{agentPoolName}/machines/{machineName}' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L1399:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L2678:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L2717:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName}' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L2759:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/locations/{location}/guardrailsVersions/{version}' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L3186:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/locations/{location}/guardrailsVersions' removed or restructured? Old: aks/preview/2023-09-02-preview/managedClusters.json#L3229:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterNodeResourceGroupProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AgentPoolWindowsProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AgentPoolSecurityProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AgentPoolGPUProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AgentPoolArtifactStreamingProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AgentPoolSSHAccess' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfileWebAppRouting' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileImageIntegrity' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileNodeRestriction' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileCustomCATrustCertificates' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshot' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshotProperties' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterPropertiesForSnapshot' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkProfileForSnapshot' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPlugin' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPluginMode' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPolicy' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkMode' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkDataplane' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkMonitoring' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'LoadBalancerSku' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GuardrailsProfile' removed or renamed? New: aks/stable/2023-10-01/managedClusters.json#L2957:3 Old: aks/preview/2023-09-02-preview/managedClusters.json#L3449:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-10 | package-2023-10(5f495af) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: aks/stable/2023-10-01/managedClusters.json#L52 |
|
Operations API path must follow the schema provided in the common types. Location: aks/stable/2023-10-01/managedClusters.json#L53 |
|
Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version. Location: aks/stable/2023-10-01/managedClusters.json#L80 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: aks/stable/2023-10-01/managedClusters.json#L137 |
|
The resource name parameter 'roleName' should be defined with a 'pattern' restriction. Location: aks/stable/2023-10-01/managedClusters.json#L278 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/stable/2023-10-01/managedClusters.json#L336 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/stable/2023-10-01/managedClusters.json#L381 |
|
format is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/stable/2023-10-01/managedClusters.json#L381 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/stable/2023-10-01/managedClusters.json#L429 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L553 |
|
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: aks/stable/2023-10-01/managedClusters.json#L639 |
|
The patch operation body parameter schema should contain property 'identity'. Location: aks/stable/2023-10-01/managedClusters.json#L658 |
|
The async patch operation should return 202. Location: aks/stable/2023-10-01/managedClusters.json#L668 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L678 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L725 |
|
The resource name parameter 'configName' should be defined with a 'pattern' restriction. Location: aks/stable/2023-10-01/managedClusters.json#L785 |
|
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/stable/2023-10-01/managedClusters.json#L955 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L999 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1151 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1252 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: aks/stable/2023-10-01/managedClusters.json#L1314 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: aks/stable/2023-10-01/managedClusters.json#L1334 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/stable/2023-10-01/managedClusters.json#L1353 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1399 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/stable/2023-10-01/managedClusters.json#L1415 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1462 |
|
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/stable/2023-10-01/managedClusters.json#L1478 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1515 |
|
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/stable/2023-10-01/managedClusters.json#L1531 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/stable/2023-10-01/managedClusters.json#L1572 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Oct 31, 2023
AzureRestAPISpecReview
added
ARMReview
new-api-version
ReadyForApiTest
This was referenced Oct 31, 2023
FumingZhang
removed
the
WaitForARMFeedback
FumingZhang
added
the
WaitForARMFeedback
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
|
There is a trivial merge conflict on file |
|
@FumingZhang you can resolve the conflict and come back with the merge request, thanks |
Merged
6 tasks
|
/pr RequestMerge |
zizw123
approved these changes
Nov 7, 2023
zizw123
deleted the
dev-containerservice-Microsoft.ContainerService-2023-10-01
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 7, 2023
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
…add version stable/2023-10-01 (#26483) * Adds base for updating Microsoft.ContainerService/aks from version stable/2023-09-01 to version 2023-10-01 * Updates readme * Updates API version in new specs and examples * Add rest api specs for node public IP IPtags and IP-based Load Balancers (#26389) * feat: add rest api spec for node public IP IPTags * feat: add rest api spec for ip-based load balancer * Add API spec for AKS HostNetwork NSG Control (#26385) * update readme (#26388) * Update custom words for ContainerService/aks 2023-10-01 (#26481) * add CapacityReservationGroup into custom-words.txt (#26461) Co-authored-by: tong chen <tonche@microsoft.com> * add lower case capacityreservationgroup (#26475) Co-authored-by: tong chen <tonche@microsoft.com> --------- Co-authored-by: Tong Chen <99183466+tonychen15@users.noreply.github.com> Co-authored-by: tong chen <tonche@microsoft.com> * restored to dev branch base (#26451) Co-authored-by: tong chen <tonche@microsoft.com> * resolve conflict (#26585) --------- Co-authored-by: Qi Ni <pomelonicky@gmail.com> Co-authored-by: Jialun Cai <jialun.cai@pm.me> Co-authored-by: Tong Chen <99183466+tonychen15@users.noreply.github.com> Co-authored-by: tong chen <tonche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.