Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.App to add version preview/2022-08-01 #20228

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JinzhaoTian
Copy link

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @JinzhaoTian Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 13, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 92 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    AuthConfigs.json 2022-08-01(9bc257f) 2022-03-01(main)
    AuthConfigs.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    CommonDefinitions.json 2022-08-01(9bc257f) 2022-03-01(main)
    CommonDefinitions.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    ContainerApps.json 2022-08-01(9bc257f) 2022-03-01(main)
    ContainerApps.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    ContainerAppsRevisions.json 2022-08-01(9bc257f) 2022-03-01(main)
    ContainerAppsRevisions.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    DaprComponents.json 2022-08-01(9bc257f) 2022-03-01(main)
    DaprComponents.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    Global.json 2022-08-01(9bc257f) 2022-03-01(main)
    Global.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    ManagedEnvironments.json 2022-08-01(9bc257f) 2022-03-01(main)
    ManagedEnvironments.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    ManagedEnvironmentsStorages.json 2022-08-01(9bc257f) 2022-03-01(main)
    ManagedEnvironmentsStorages.json 2022-08-01(9bc257f) 2022-01-01-preview(main)
    SourceControls.json 2022-08-01(9bc257f) 2022-03-01(main)
    SourceControls.json 2022-08-01(9bc257f) 2022-01-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ContainerAppPatch' removed or renamed?
    New: Microsoft.App/preview/2022-08-01/ContainerApps.json#L413:3
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L415:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedEnvironmentPatch' removed or renamed?
    New: Microsoft.App/preview/2022-08-01/ManagedEnvironments.json#L648:3
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L591:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'apiVersionParameter' removed or renamed?
    New: azure-rest-api-specs/blob/9bc257fa794d26b3fb829bdcdff84102bcb7ea5d/revision#L223:2
    Old: Microsoft.App/preview/2022-01-01-preview/Global.json#L122:3
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/AuthConfigs.json#L88:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/AuthConfigs.json#L140:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/AuthConfigs.json#L201:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L113:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L162:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L223:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L272:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L385:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L88:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L141:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L191:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L248:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L354:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/DaprComponents.json#L88:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/DaprComponents.json#L140:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/DaprComponents.json#L202:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L116:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L161:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L222:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L271:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'managedEnvironmentName' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L327:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'managedEnvironmentName' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L377:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L384:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'managedEnvironmentName' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L429:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L436:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'managedEnvironmentName' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L489:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'name' was removed in the new version.
    Old: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L496:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 1 Errors, 14 Warnings failed [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-08 package-preview-2022-08(9bc257f) default(main)

    The following errors/warnings are introduced by current PR:

    Rule Message
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'disableWWWAuthenticate', for definition: 'AzureActiveDirectoryLogin' must follow camelCase style. Example: 'disableWwwAuthenticate'.
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L547
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L298
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireHttps
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L343
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: preserveUrlFragmentsForLogins
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L402
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateNonce
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L459
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L514
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAutoProvisioned
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L530
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableWWWAuthenticate
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L547
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L665
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L714
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L746
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L781
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L809
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L841
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L865


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironments.json#L854
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L290
    ⚠️ R2015 - ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-08-01/CommonDefinitions.json#L1
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L119
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L180
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L148
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L209
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L19
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L66
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L118
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L179
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/SourceControls.json#L137
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-08-01/SourceControls.json#L205
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerAppsRevisionReplicas_ListReplicas' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/preview/2022-08-01/ContainerAppsRevisions.json#L289
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ManagedEnvironmentsStorages_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L19
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'authConfigs' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/AuthConfigs.json#L256
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'revisions' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/ContainerAppsRevisions.json#L393
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'replicas' with immediate parent 'Revision', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/ContainerAppsRevisions.json#L500
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'daprComponents' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/DaprComponents.json#L311
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'certificates' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironments.json#L845
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'storages' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/ManagedEnvironmentsStorages.json#L281
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-08-01/SourceControls.json#L264
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L561
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: external
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L597
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowInsecure
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L640
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: latestRevision
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L717
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isHostnameAlreadyVerified
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L767
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hasConflictOnManagedEnvironment
    Location: Microsoft.App/preview/2022-08-01/ContainerApps.json#L837
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: ready
    Location: Microsoft.App/preview/2022-08-01/ContainerAppsRevisions.json#L562
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: started
    Location: Microsoft.App/preview/2022-08-01/ContainerAppsRevisions.json#L566
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.App' for api version '2022-08-01'. The supported api-versions are '2022-01-01-preview,
    2022-03-01,
    2022-06-01-preview'."
    ️❌~[Staging] ServiceAPIReadinessTest: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'containerApps' should be deployed in 'West Central US' on apiVersion '2022-08-01'.: expected [ Array(13) ] to satisfy [Function]"
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'containerApps' should be deployed in 'West Central US' on apiVersion '2022-08-01'.: expected [ Array(13) ] to satisfy [Function]"
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/9bc257fa794d26b3fb829bdcdff84102bcb7ea5d/specification/app/resource-manager/readme.md#tag-package-preview-2022-08">app/resource-manager/readme.md#package-preview-2022-08
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"app/resource-manager/readme.md",
    "tag":"package-preview-2022-08",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 13, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armappcontainers - 2.0.0
    -	Field `CertificateEnvelope` of struct `CertificatesClientCreateOrUpdateOptions` has been removed
    -	Function `*CertificatesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *CertificatesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, Certificate, *CertificatesClientCreateOrUpdateOptions)`
    azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - 1.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 97bfa894b378ae9ede9eb1d5d20c9311a6278c07. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter id
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter name
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter system_data
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter type
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 97bfa894b378ae9ede9eb1d5d20c9311a6278c07. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CustomHostnameAnalysisResultProperties` has been removed
      info	[Changelog] - Field `ID` of struct `CustomHostnameAnalysisResult` has been removed
      info	[Changelog] - Field `Name` of struct `CustomHostnameAnalysisResult` has been removed
      info	[Changelog] - Field `SystemData` of struct `CustomHostnameAnalysisResult` has been removed
      info	[Changelog] - Field `Type` of struct `CustomHostnameAnalysisResult` has been removed
      info	[Changelog] - Field `Properties` of struct `CustomHostnameAnalysisResult` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo`
      info	[Changelog] - New struct `CustomHostnameAnalysisResultCustomDomainVerificationFailureInfoDetailsItem`
      info	[Changelog] - New field `HasConflictOnManagedEnvironment` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `ARecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CustomDomainVerificationFailureInfo` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CustomDomainVerificationTest` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `HostName` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `AlternateCNameRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `TxtRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CNameRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `AlternateTxtRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `IsHostnameAlreadyVerified` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `ConflictingContainerAppResourceID` in struct `CustomHostnameAnalysisResult`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 5 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 97bfa894b378ae9ede9eb1d5d20c9311a6278c07. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appcontainers [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface AuthConfig
      info	[Changelog]   - Added Interface Certificate
      info	[Changelog]   - Added Interface ContainerApp
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResult
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
      info	[Changelog]   - Added Interface CustomHostnameAnalysisResultCustomDomainVerificationFailureInfoDetailsItem
      info	[Changelog]   - Added Interface DaprComponent
      info	[Changelog]   - Added Interface ManagedEnvironment
      info	[Changelog]   - Added Interface ManagedEnvironmentStorage
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface Replica
      info	[Changelog]   - Added Interface Revision
      info	[Changelog]   - Added Interface SourceControl
      info	[Changelog]   - Added Interface TrackedResource
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 97bfa894b378ae9ede9eb1d5d20c9311a6278c07. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 97bfa894b378ae9ede9eb1d5d20c9311a6278c07. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ContainerAppsApi [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 13, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-appcontainers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-appcontainers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-appcontainers Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @JinzhaoTian, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @JinzhaoTian
    Copy link
    Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    Copy link

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has breaking changes in the generated SDK for go (label: CI-BreakingChange-Go). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    Copy link
    Contributor

    @JinzhaoTian please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

    @microsoft-github-policy-service agree [company="{your company}"]
    

    Options:

    • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
    @microsoft-github-policy-service agree
    
    • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
    @microsoft-github-policy-service agree company="Microsoft"
    
    Contributor License Agreement

    Contribution License Agreement

    This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
    and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
    contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
    date below.

    1. Definitions.
      “Code” means the computer software code, whether in human-readable or machine-executable form,
      that is delivered by You to Microsoft under this Agreement.
      “Project” means any of the projects owned or managed by Microsoft and offered under a license
      approved by the Open Source Initiative (www.opensource.org).
      “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
      Project, including but not limited to communication on electronic mailing lists, source code control
      systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
      discussing and improving that Project, but excluding communication that is conspicuously marked or
      otherwise designated in writing by You as “Not a Submission.”
      “Submission” means the Code and any other copyrightable material Submitted by You, including any
      associated comments and documentation.
    2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
      Project. This Agreement covers any and all Submissions that You, now or in the future (except as
      described in Section 4 below), Submit to any Project.
    3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
      Should You wish to Submit materials that are not Your original work, You may Submit them separately
      to the Project if You (a) retain all copyright and license information that was in the materials as You
      received them, (b) in the description accompanying Your Submission, include the phrase “Submission
      containing materials of a third party:” followed by the names of the third party and any licenses or other
      restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
      guidelines concerning Submissions.
    4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
      for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
      Submission is made in the course of Your work for an employer or Your employer has intellectual
      property rights in Your Submission by contract or applicable law, You must secure permission from Your
      employer to make the Submission before signing this Agreement. In that case, the term “You” in this
      Agreement will refer to You and the employer collectively. If You change employers in the future and
      desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
      and secure permission from the new employer before Submitting those Submissions.
    5. Licenses.
    • Copyright License. You grant Microsoft, and those who receive the Submission directly or
      indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
      Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
      the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
      parties.
    • Patent License. You grant Microsoft, and those who receive the Submission directly or
      indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
      Your patent claims that are necessarily infringed by the Submission or the combination of the
      Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
      import or otherwise dispose of the Submission alone or with the Project.
    • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
      No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
      granted by implication, exhaustion, estoppel or otherwise.
    1. Representations and Warranties. You represent that You are legally entitled to grant the above
      licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
      have disclosed under Section 3). You represent that You have secured permission from Your employer to
      make the Submission in cases where Your Submission is made in the course of Your work for Your
      employer or Your employer has intellectual property rights in Your Submission by contract or applicable
      law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
      have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
      You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
      REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
      EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
      PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
      NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
    2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
      You later become aware that would make Your representations in this Agreement inaccurate in any
      respect.
    3. Information about Submissions. You agree that contributions to Projects and information about
      contributions may be maintained indefinitely and disclosed publicly, including Your name and other
      information that You submit with Your Submission.
    4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
      the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
      Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
      exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
      defenses of lack of personal jurisdiction and forum non-conveniens.
    5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
      supersedes any and all prior agreements, understandings or communications, written or oral, between
      the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants