-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recoveryservicesbackup: marking the LRO operations as LROs #18269
base: main
Are you sure you want to change the base?
recoveryservicesbackup: marking the LRO operations as LROs #18269
Conversation
These not being marked as an LRO means that consumers of the API need to instead manually parse the header to make these work, as can be seen in this commit: https://github.com/hashicorp/terraform-provider-azurerm/blob/4d39dde5bd2ff7b40ecbed0db93d35bf4ea5646d/internal/services/recoveryservices/backup_container_storage_account_resource.go#L97-L117 This PR fixes this by correctly marking these operations as LROs - which is a bug as the operation description explicitly defines these operations are an LRO
Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Waiting on the Service Team.. |
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Waiting on the Service Team.. |
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
@jianyexi the PR is valid and up to date, it's just waiting for a review from the Service Team - unfortunately I can't re-open this PR since you've closed it, so can you please re-open this PR. Thanks. |
Generated ApiView
|
Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
These not being marked as an LRO means that consumers of the API need to instead manually parse the header
to make these work, as can be seen in this commit:
https://github.com/hashicorp/terraform-provider-azurerm/blob/4d39dde5bd2ff7b40ecbed0db93d35bf4ea5646d/internal/services/recoveryservices/backup_container_storage_account_resource.go#L97-L117
This PR fixes this by correctly marking these operations as LROs - which is a bug as the operation description explicitly defines these operations are an LRO