Small update to message from linter CI #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
reviewed
Sep 28, 2017
| @@ -114,7 +114,7 @@ describe('AutoRest Linter validation:', function () { | |||
| prFile += ''; | |||
| return prFile.startsWith(configDir) && prFile.indexOf('examples') === -1 && prFile.endsWith('.json'); | |||
| }).forEach(prFileInConfigFile => { | |||
| console.warn(`Configuration file not found for file: ${prFileInConfigFile}, running validation rules against it in individual context.`); | |||
| console.warn(`WARNING: Configuration file not found for file: ${prFileInConfigFile}, running validation rules against it in individual context.`); | |||
There was a problem hiding this comment.
nit: Wonder if we should integrate this in the validator itself.
There was a problem hiding this comment.
@dsgouda Maybe, feel free to open an issue on the validator if you think we should move the check there, and we can evaluate. I wouldn't want to change it as part of this change.
vishrutshah
approved these changes
Sep 28, 2017
|
No modification for AutorestCI/azure-sdk-for-ruby |
|
No modification for AutorestCI/azure-sdk-for-node |
|
No modification for AutorestCI/azure-sdk-for-ruby |
|
No modification for AutorestCI/azure-sdk-for-node |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating warning message to be a bit more noticeable, as I missed it once already (PR validation fell back to single file, which was fine for that case, but should have realized this was there due to a typo in name of the file that was pointed from the readme.md).