-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small update to message from linter CI #1769
Conversation
@@ -114,7 +114,7 @@ describe('AutoRest Linter validation:', function () { | |||
prFile += ''; | |||
return prFile.startsWith(configDir) && prFile.indexOf('examples') === -1 && prFile.endsWith('.json'); | |||
}).forEach(prFileInConfigFile => { | |||
console.warn(`Configuration file not found for file: ${prFileInConfigFile}, running validation rules against it in individual context.`); | |||
console.warn(`WARNING: Configuration file not found for file: ${prFileInConfigFile}, running validation rules against it in individual context.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Wonder if we should integrate this in the validator itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsgouda Maybe, feel free to open an issue on the validator if you think we should move the check there, and we can evaluate. I wouldn't want to change it as part of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No modification for AutorestCI/azure-sdk-for-ruby |
No modification for AutorestCI/azure-sdk-for-node |
No modification for AutorestCI/azure-sdk-for-ruby |
No modification for AutorestCI/azure-sdk-for-node |
Updating warning message to be a bit more noticeable, as I missed it once already (PR validation fell back to single file, which was fine for that case, but should have realized this was there due to a typo in name of the file that was pointed from the readme.md).