[Hub Generated] Public private branch 'dev-digitaltwins-Microsoft.DigitalTwins-2021-06-30-preview-merge-with-main' #17186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-12-01 to version 2021-06-30-preview
* Add SDK Generation Options for new API Version (#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com>
…dev-digitaltwins-Microsoft.DigitalTwins-2021-06-30-preview-merge-with-main
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5702 |
sjiherzig
requested review from
ArcturusZhang,
BigCat20196,
msyyc and
RAY-316
as code owners
|
Hi, @sjiherzig Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @sjiherzig, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Dec 28, 2021
|
Hi, @sjiherzig. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
Can this PR please be merged? It was already approved in the private specs repo. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @sjiherzig, Is your service for new version deployed to production? if yes, I will help you merge. |
|
Yes, the service has been deployed, but the API version is still behind a feature flag. We will be removing this flag in the next 1-2 weeks. We're ready to merge. |
akning-ms
approved these changes
Feb 1, 2022
This was referenced Feb 1, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Feb 1, 2022
…igitaltwins-Microsoft.DigitalTwins-2021-06-30-preview-merge-with-main' (#2188) Create to sync Azure/azure-rest-api-specs#17186 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/digitaltwins?expand=1)
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
…italTwins-2021-06-30-preview-merge-with-main' (Azure#17186) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (Azure#3404) * Add SDK Generation Options for new API Version (Azure#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (Azure#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (Azure#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com> * Align with repo (Azure#5658) Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com>
JackTn
deleted the
published/Azure/azure-rest-api-specs-pr/dev-digitaltwins-Microsoft.DigitalTwins-2021-06-30-preview-merge-with-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.