Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed network resources, updates from previous version #14217

Merged
merged 1 commit into from
May 13, 2021

Conversation

guptas14
Copy link
Contributor

@guptas14 guptas14 commented May 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ghost ghost added the Network label May 3, 2021
@openapi-workflow-bot
Copy link

Hi, @guptas14 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 3, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/27aacd8a3ced921a28e75aa17043f741f6d5d16a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01",
    "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/oad@0.8.9/node_modules/autorest/dist/app.js /tmp/readme.oad.old.md --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nKilled\n"
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2020-11-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2020-11-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2020-11-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/preview/2021-02-01-preview/network.json#L300
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2020-11-01/network.json#L221
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/stable/2020-11-01/network.json#L221
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces'
    Location: Microsoft.Network/stable/2020-11-01/vmssNetworkInterface.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/networkInterfaces'
    Location: Microsoft.Network/stable/2020-11-01/vmssNetworkInterface.json#L97
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}'
    Location: Microsoft.Network/stable/2020-11-01/vmssNetworkInterface.json#L150
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}/ipConfigurations'
    Location: Microsoft.Network/stable/2020-11-01/vmssNetworkInterface.json#L221
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2020-11-01/virtualNetwork.json
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    PreCheck/DuplicateSchema "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:4052" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:4056" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-11",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-11",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-11",
    "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-11",
    "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration"
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-11",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 3, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-network - 18.0.0
    +	Model VirtualNetworkGateway no longer has parameter virtual_network_extended_location
    +	Operation VirtualNetworkPeeringsOperations.begin_create_or_update has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f5fb710. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f5fb710. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model NetworkInterfaceIPConfiguration has a new parameter type
      info	[Changelog]   - Model NetworkInterfaceIPConfiguration has a new parameter gateway_load_balancer
      info	[Changelog]   - Model CustomIpPrefix has a new parameter signed_message
      info	[Changelog]   - Model CustomIpPrefix has a new parameter child_custom_ip_prefixes
      info	[Changelog]   - Model CustomIpPrefix has a new parameter authorization_message
      info	[Changelog]   - Model CustomIpPrefix has a new parameter custom_ip_prefix_parent
      info	[Changelog]   - Model CustomIpPrefix has a new parameter failed_reason
      info	[Changelog]   - Model AvailablePrivateEndpointType has a new parameter display_name
      info	[Changelog]   - Model LoadBalancingRule has a new parameter backend_address_pools
      info	[Changelog]   - Model PublicIPPrefix has a new parameter nat_gateway
      info	[Changelog]   - Model Subnet has a new parameter type
      info	[Changelog]   - Model Subnet has a new parameter application_gateway_ip_configurations
      info	[Changelog]   - Model VirtualHub has a new parameter preferred_routing_gateway
      info	[Changelog]   - Model ApplicationGatewayTrustedClientCertificate has a new parameter client_cert_issuer_dn
      info	[Changelog]   - Model ApplicationGatewayTrustedClientCertificate has a new parameter validated_cert_data
      info	[Changelog]   - Model VirtualNetwork has a new parameter flow_timeout_in_minutes
      info	[Changelog]   - Model PublicIPAddress has a new parameter linked_public_ip_address
      info	[Changelog]   - Model PublicIPAddress has a new parameter service_public_ip_address
      info	[Changelog]   - Model PublicIPAddress has a new parameter delete_option
      info	[Changelog]   - Model PublicIPAddress has a new parameter nat_gateway
      info	[Changelog]   - Model PublicIPAddress has a new parameter migration_phase
      info	[Changelog]   - Model VirtualNetworkGatewayConnection has a new parameter ingress_nat_rules
      info	[Changelog]   - Model VirtualNetworkGatewayConnection has a new parameter egress_nat_rules
      info	[Changelog]   - Model Delegation has a new parameter type
      info	[Changelog]   - Model FrontendIPConfiguration has a new parameter gateway_load_balancer
      info	[Changelog]   - Model IPAddressAvailabilityResult has a new parameter is_platform_reserved
      info	[Changelog]   - Model BackendAddressPool has a new parameter tunnel_interfaces
      info	[Changelog]   - Model ServiceTagInformationPropertiesFormat has a new parameter state
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter do_not_verify_remote_gateways
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter remote_virtual_network_address_space
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter resource_guid
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter peering_sync_level
      info	[Changelog]   - Model VirtualNetworkPeering has a new parameter type
      info	[Changelog]   - Model EffectiveNetworkSecurityGroupAssociation has a new parameter network_manager
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter extended_location
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter enable_bgp_route_translation_for_nat
      info	[Changelog]   - Model VirtualNetworkGateway has a new parameter nat_rules
      info	[Changelog]   - Model BastionHost has a new parameter sku
      info	[Changelog]   - Model NetworkInterface has a new parameter workload_type
      info	[Changelog]   - Model NetworkInterface has a new parameter private_link_service
      info	[Changelog]   - Model NetworkInterface has a new parameter nic_type
      info	[Changelog]   - Model NetworkInterface has a new parameter migration_phase
      info	[Changelog]   - Added operation LoadBalancersOperations.begin_swap_public_ip_addresses
      info	[Changelog]   - Added operation group VirtualNetworkGatewayNatRulesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation VirtualNetworkPeeringsOperations.begin_create_or_update has a new signature
      info	[Changelog]   - Model VirtualNetworkGateway no longer has parameter virtual_network_extended_location
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f5fb710. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-13 03:49:10 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated"
      cmderr	[generate.py] 2021-05-13 03:49:10 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-05-13 03:49:10 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.27 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-13 03:52:45 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG Got artifact_id: azure-resourcemanager-network-generated
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-13 04:01:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14217/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f5fb710. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
      cmderr	[npmPack] created ./dist/arm-network.js in 2.8s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f5fb710. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @guptas14
    Copy link
    Contributor Author

    guptas14 commented May 3, 2021

    Changes made based on previous fixes based on S360 checks.
    These changes are not present in 2020-11-01 version of Microsoft.Network.

    #12570

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Copy link
    Member

    @weidongxu-microsoft weidongxu-microsoft left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    exists in 2020-08

    @kairu-ms kairu-ms removed their assignment May 7, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 8, 2021
    @lirenhe
    Copy link
    Member

    lirenhe commented May 11, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe
    Copy link
    Member

    lirenhe commented May 12, 2021

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    This was referenced May 13, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @JackTn JackTn deleted the nrp-swagger-fixes-2020-11-01 branch August 17, 2021 06:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360 Network
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants