Datr/reg info and enums #12766
Merged
Datr/reg info and enums #12766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-02-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
datr93
force-pushed
the
datr/regInfoAndEnums
branch
from
6b9643b
to
60c0882
Compare
|
Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
remove pagination refactor and remove regtoken in example rename rename
datr93
force-pushed
the
datr/regInfoAndEnums
branch
from
3291d30
to
921b213
Compare
|
@weidongxu-microsoft is the ci pipeline broken? I see many people with same python error. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @weidongxu-microsoft |
|
Appear to be CI issue. You can ignore it for now. Maybe later it will get fixed. If you have commit id that is the real change (instead of copy/bump up version etc.), please write it in description. Multiple party is going to review the PR and it saves time. |
|
spellcheck need to be fixed.
|
|
@weidongxu-microsoft anyone looking at this pr from the arm side? |
|
@datr93 You can email "Azure Resource Manager RP API Review armapireview@microsoft.com" if urgent (usually "WaitForARMFeedback" label will do, but this month seems got lots of PR). |
jorgecotillo
added
ARMSignedOff
|
@weidongxu-microsoft can you approve the pr. Got arm sign off! |
weidongxu-microsoft
approved these changes
Feb 6, 2021
weidongxu-microsoft
added
the
Approved-OkToMerge
|
@datr93 |
|
@weidongxu-microsoft pls merge! Thanks!! |
This was referenced Feb 9, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* copy over * change version * update readme * fix ruby more * add Retrieveregistrationtoken remove pagination refactor and remove regtoken in example rename rename * add enums and better descriptions * model as string true * add FSLogix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.