Update ResourceIdentity reference and remove ManagedInstanceMetric #11960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/managedInstances/{managedInstanceName}/metricDefinitions' removed or restructured? New: azure-rest-api-specs/blob/cc8b1c8d2d202c2482180872a6f301dcc25617e1/ Old: Microsoft.Sql/preview/2020-08-01-preview/ManagedInstances.json#L19:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/managedInstances/{managedInstanceName}/metrics' removed or restructured? New: azure-rest-api-specs/blob/cc8b1c8d2d202c2482180872a6f301dcc25617e1/ Old: Microsoft.Sql/preview/2020-08-01-preview/ManagedInstances.json#L61:5 |
|
The new version is adding enum value(s) 'UserAssigned' from the old version. New: resource-manager/common/v1/types.json#L168:9 Old: Microsoft.Sql/preview/2020-08-01-preview/ManagedInstances.json#L930:9 |
|
The new version is adding enum value(s) 'None, UserAssigned' from the old version. New: resource-manager/common/v1/types.json#L168:9 Old: Microsoft.Sql/preview/2019-06-01-preview/servers.json#L359:9 |
|
The new version is adding enum value(s) 'UserAssigned' from the old version. New: resource-manager/common/v1/types.json#L168:9 Old: Microsoft.Sql/preview/2020-08-01-preview/Servers.json#L359:9 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Swagger Generation Artifacts
|
ericshape
changed the title
|
Hi @ericshape, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Dec 4, 2020
|
@PhoenixHe-msft could you have a look at the failure of SDK azure-sdk-for-java |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The Java automation is not blocking the PR merge. And it shows in log that the Java generation is successful. |
|
Hi @ericschung, can I know when ManagedInstanceMetric is added? in which PR? |
akning-ms
reviewed
Dec 8, 2020
@akning-ms BTW, you might tag the wrong ID LOL |
jamestao
approved these changes
Dec 8, 2020
|
@akning-ms BTW, the upcoming PR is ready: #11840 and it passed all the checks. Can you help to take a look? |
25 tasks
|
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
akning-ms
added
Approved-BreakingChange
This was referenced Dec 9, 2020
Closed
[ReleasePR Microsoft.Azure.Management.Sql] add sql tag to readme.go.md
Azure/azure-sdk-for-net#17306
Closed
DeMale
pushed a commit
to DeMale/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2020
…zure#11960) * update ResourceIdentity reference * Change IdentityTypeWithNone to IdentityType
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…zure#11960) * update ResourceIdentity reference * Change IdentityTypeWithNone to IdentityType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes in this PR are auto-generated by SQL DB DSMainDev Repo:
NoneandUserAssignedto ResourceIdentity in SQL specific common type file: https://github.com/ericshape/azure-rest-api-specs/blob/33b5733cc82028c9ce6e2c9ec9f28e7f763098f7/specification/sql/resource-manager/common/v1/types.json#L100-L129 manually changeMSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.