From 7bcd5c9f6e70007115584c2b9c1adb66676f5c31 Mon Sep 17 00:00:00 2001 From: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com> Date: Sun, 24 Jan 2021 18:03:16 -0800 Subject: [PATCH] No snat firewall policy (#12505) * Adding No SNAT feature support to firewall policy * committing prettier-fix * adding period at end of description to prevent failure for checks --- .../2020-11-01/webapplicationfirewall.json | 35 +++++++++---------- .../examples/FirewallPolicyGet.json | 5 +++ .../FirewallPolicyListByResourceGroup.json | 5 +++ .../FirewallPolicyListBySubscription.json | 5 +++ .../examples/FirewallPolicyPut.json | 15 ++++++++ .../stable/2020-11-01/firewallPolicy.json | 17 +++++++++ 6 files changed, 64 insertions(+), 18 deletions(-) diff --git a/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json b/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json index e99c00931d41..b3d6bec99686 100644 --- a/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json +++ b/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json @@ -1,4 +1,3 @@ - { "swagger": "2.0", "info": { @@ -339,24 +338,24 @@ } }, "Sku": { - "description": "The pricing tier of the web application firewall policy.", - "properties": { - "name": { - "description": "Name of the pricing tier.", - "enum": [ - "Classic_AzureFrontDoor", - "Standard_AzureFrontDoor", - "Premium_AzureFrontDoor" - ], - "type": "string", - "x-ms-enum": { - "name": "SkuName", - "modelAsString": true + "description": "The pricing tier of the web application firewall policy.", + "properties": { + "name": { + "description": "Name of the pricing tier.", + "enum": [ + "Classic_AzureFrontDoor", + "Standard_AzureFrontDoor", + "Premium_AzureFrontDoor" + ], + "type": "string", + "x-ms-enum": { + "name": "SkuName", + "modelAsString": true + } } - } + }, + "type": "object" }, - "type": "object" - }, "WebApplicationFirewallPolicyList": { "description": "Defines a list of WebApplicationFirewallPolicies. It contains a list of WebApplicationFirewallPolicy objects and a URL link to get the next set of results.", "properties": { @@ -951,4 +950,4 @@ "description": "Name of the Resource group within the Azure subscription." } } -} \ No newline at end of file +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyGet.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyGet.json index 59de7e5a7dbf..6f9d73984225 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyGet.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyGet.json @@ -33,6 +33,11 @@ } ], "firewalls": [], + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListByResourceGroup.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListByResourceGroup.json index 8dd05ce67c7e..210acbcf2b71 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListByResourceGroup.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListByResourceGroup.json @@ -26,6 +26,11 @@ } ], "firewalls": [], + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListBySubscription.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListBySubscription.json index 6264f21dad62..6594f7b35ec6 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListBySubscription.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyListBySubscription.json @@ -25,6 +25,11 @@ } ], "firewalls": [], + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyPut.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyPut.json index 5ed0883ab563..10935f0f83f8 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyPut.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/examples/FirewallPolicyPut.json @@ -19,6 +19,11 @@ "*.microsoft.com" ] }, + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" @@ -96,6 +101,11 @@ } ], "firewalls": [], + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" @@ -172,6 +182,11 @@ } ], "firewalls": [], + "snat": { + "privateRanges": [ + "IANAPrivateRanges" + ] + }, "dnsSettings": { "servers": [ "30.3.4.5" diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/firewallPolicy.json b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/firewallPolicy.json index ba62fd959659..e96788fbb414 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/firewallPolicy.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2020-11-01/firewallPolicy.json @@ -638,6 +638,10 @@ "description": "ThreatIntel Whitelist for Firewall Policy.", "$ref": "#/definitions/FirewallPolicyThreatIntelWhitelist" }, + "snat": { + "description": "The private IP addresses/IP ranges to which traffic will not be SNAT.", + "$ref": "#/definitions/FirewallPolicySNAT" + }, "dnsSettings": { "description": "DNS Proxy Settings definition.", "$ref": "#/definitions/DnsSettings" @@ -1146,6 +1150,19 @@ } } }, + "FirewallPolicySNAT": { + "description": "The private IP addresses/IP ranges to which traffic will not be SNAT.", + "x-ms-discriminator-value": "FirewallPolicySNAT", + "properties": { + "privateRanges": { + "type": "array", + "description": "List of private IP addresses/IP address ranges to not be SNAT.", + "items": { + "type": "string" + } + } + } + }, "DnsSettings": { "description": "DNS Proxy Settings in Firewall Policy.", "x-ms-discriminator-value": "DnsSettings",