From 638734a059c4575d098a8ed8b0faf75c397f3425 Mon Sep 17 00:00:00 2001 From: najian Date: Fri, 3 Feb 2023 09:34:40 +0800 Subject: [PATCH] Fix S360 swagger error, certificateId not required (#22339) * Fix S360 swagger error, certificateId not required Fix S360 swagger error, certificateId not required per service behavior * Update ContainerApps_ListCustomHostNameAnalysisErrorResponse.json fix example error --------- Co-authored-by: Nan Jiang --- .../preview/2022-01-01-preview/ContainerApps.json | 5 ++--- .../preview/2022-06-01-preview/ContainerApps.json | 5 ++--- .../Microsoft.App/stable/2022-03-01/ContainerApps.json | 5 ++--- ...ontainerApps_ListCustomHostNameAnalysisErrorResponse.json | 2 +- .../Microsoft.App/stable/2022-10-01/ContainerApps.json | 5 ++--- 5 files changed, 9 insertions(+), 13 deletions(-) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json index 093d0d09eec6..5a2bf301dd19 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json @@ -737,8 +737,7 @@ "description": "Custom Domain of a Container App", "type": "object", "required": [ - "name", - "certificateId" + "name" ], "properties": { "name": { @@ -758,7 +757,7 @@ } }, "certificateId": { - "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.", + "description": "Resource Id of the Certificate to be bound to this hostname.", "type": "string" } } diff --git a/specification/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json index 180198898a14..69cc06ae5068 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json @@ -860,8 +860,7 @@ "description": "Custom Domain of a Container App", "type": "object", "required": [ - "name", - "certificateId" + "name" ], "properties": { "name": { @@ -881,7 +880,7 @@ } }, "certificateId": { - "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.", + "description": "Resource Id of the Certificate to be bound to this hostname.", "type": "string" } } diff --git a/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json index de43a5044155..06b45f8a030b 100644 --- a/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json @@ -741,8 +741,7 @@ "description": "Custom Domain of a Container App", "type": "object", "required": [ - "name", - "certificateId" + "name" ], "properties": { "name": { @@ -762,7 +761,7 @@ } }, "certificateId": { - "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.", + "description": "Resource Id of the Certificate to be bound to this hostname.", "type": "string" } } diff --git a/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json b/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json index 304bf1a1fa56..21dfa5acbb21 100644 --- a/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json +++ b/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json @@ -4,7 +4,7 @@ "resourceGroupName": "rg", "containerAppName": "testcontainerApp0", "customHostname": "my.name.corp", - "api-version": "2022-03-03" + "api-version": "2022-03-01" }, "responses": { "200": { diff --git a/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json index 21bd9c1a2989..e38965393a4b 100644 --- a/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json +++ b/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json @@ -882,8 +882,7 @@ "description": "Custom Domain of a Container App", "type": "object", "required": [ - "name", - "certificateId" + "name" ], "properties": { "name": { @@ -903,7 +902,7 @@ } }, "certificateId": { - "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.", + "description": "Resource Id of the Certificate to be bound to this hostname.", "type": "string" } }