Skip to content

[CognitiveServices] Support getting account types (kinds). #7519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from Oct 23, 2018
Merged

[CognitiveServices] Support getting account types (kinds). #7519

merged 6 commits into from Oct 23, 2018

Conversation

yangyuan
Copy link
Member

Add Get-AzureRmCognitiveServicesAccountType cmdlet to allow customers to get available kind names.

Checklist

Design Review:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/177

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Get-AzCognitiveServicesAccountType needs to be added to Az.CognitiveServices.psd1

@yangyuan
Copy link
Member Author

@MiYanni

Do you mean add Get-AzCognitiveServicesAccountType to CmdletsToExport????

Right now in Az.CognitiveServices.psd1:

CmdletsToExport = 'Get-AzureRmCognitiveServicesAccount', 
               'Get-AzureRmCognitiveServicesAccountKey', 
               'Get-AzureRmCognitiveServicesAccountSkus', 
               'Get-AzureRmCognitiveServicesAccountType', 
               'Get-AzureRmCognitiveServicesAccountUsage', 
               'New-AzureRmCognitiveServicesAccount', 
               'New-AzureRmCognitiveServicesAccountKey', 
               'Remove-AzureRmCognitiveServicesAccount', 
               'Set-AzureRmCognitiveServicesAccount'

So I added Get-AzureRmCognitiveServicesAccountType and also added the alias mapping.

@MiYanni
Copy link
Contributor

MiYanni commented Oct 13, 2018

@yangyuan Yes. CmdletsToExport in Az.CognitiveServices.psd1 should have the same list as what is in AzureRM.CognitiveServices.psd1.

@MiYanni
Copy link
Contributor

MiYanni commented Oct 17, 2018

@yangyuan Ping

@yangyuan
Copy link
Member Author

@MiYanni, sorry for late response, got stuck in some other tasks.

Will try to finish this RP today,

MiYanni and others added 2 commits October 22, 2018 14:57
…itiveServices/CognitiveServicesAccount/CognitiveServicesAccountBaseCmdlet.cs

Co-Authored-By: yangyuan <6941987@qq.com>
Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiYanni MiYanni merged commit 185b706 into Azure:preview Oct 23, 2018
@yangyuan yangyuan deleted the yuanyang/types branch March 12, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants