Skip to content

Fix flaky long running operation test #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2018
Merged

Fix flaky long running operation test #6204

merged 3 commits into from
May 23, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

markcowl
markcowl previously requested changes May 23, 2018
View reviewed changes
src/ResourceManager/Profile/Commands.Profile.Test/LongRunningCmdletTests.cs
@@ -265,7 +265,7 @@ void WaitForCompletion(AzureLongRunningJob job, Action<AzureLongRunningJob> vali
try
{
HandleStateChange(job, new JobStateEventArgs(job.JobStateInfo, new JobStateInfo(JobState.NotStarted)));
this.jobCompleted.WaitOne(TimeSpan.FromSeconds(30));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just make this arbitrarily large (like FromHours(4)?

@markcowl markcowl assigned maddieclayton and unassigned markcowl May 23, 2018
@maddieclayton
Copy link
Contributor Author

on demand job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/875/

@cormacpayne cormacpayne dismissed markcowl’s stale review May 23, 2018 21:46

Comment resolved

@cormacpayne cormacpayne merged commit 3def3c8 into Azure:preview May 23, 2018
@maddieclayton maddieclayton deleted the fixLRT branch May 23, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@markcowl markcowl markcowl left review comments

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddieclayton @markcowl @cormacpayne @azuresdkci