-
Notifications
You must be signed in to change notification settings - Fork 4k
Add new cmdlets for storage SAS token stored policy. #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @EmmaZhu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@@ -158,6 +159,16 @@ public QueuePermissions GetPermissions(CloudQueue queue, QueueRequestOptions opt | |||
throw new NotImplementedException(); | |||
} | |||
|
|||
public Task<QueuePermissions> GetPermissionsAsync(CloudQueue queue, QueueRequestOptions requestOptions, OperationContext operationContext) | |||
{ | |||
throw new NotImplementedException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to have this given its not implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mock class used in test cases. It implements an interface which has this method in it. But we don't need to use this method in test cases, so just leave it to be not implemented..
@EmmaZhu merge conflicts, please update |
bug1822377 and removing quotes
Update Vmss tests
Add new cmdlets for storage SAS token stored policy.