Skip to content

Add new cmdlets for storage SAS token stored policy. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Dec 18, 2014

Add new cmdlets for storage SAS token stored policy.

@azurecla
Copy link

Hi @EmmaZhu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@@ -158,6 +159,16 @@ public QueuePermissions GetPermissions(CloudQueue queue, QueueRequestOptions opt
throw new NotImplementedException();
}

public Task<QueuePermissions> GetPermissionsAsync(CloudQueue queue, QueueRequestOptions requestOptions, OperationContext operationContext)
{
throw new NotImplementedException();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to have this given its not implemented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mock class used in test cases. It implements an interface which has this method in it. But we don't need to use this method in test cases, so just leave it to be not implemented..

@markcowl
Copy link
Member

@EmmaZhu merge conflicts, please update

@EmmaZhu EmmaZhu closed this Jan 21, 2015
markcowl pushed a commit that referenced this pull request Feb 26, 2015
bug1822377 and removing quotes
ogail pushed a commit that referenced this pull request Jul 7, 2015
Fix for TargetACR bug - 2092109
stankovski pushed a commit that referenced this pull request Jul 10, 2015
huangpf added a commit that referenced this pull request Jul 29, 2015
DeepakRajendranMsft pushed a commit to DeepakRajendranMsft/azure-powershell that referenced this pull request Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants