Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet #28

edumunoz · 2014-12-05T01:23:15Z

Right now in Set-AzureNetworkSecurityGroupToSubnet exceptions are being caught in case we can automatically handle them (when a user is trying to change the NSG that applies to a subnet already having an NSG).

However, if the exception is not the one we can handle automatically, we should rethrow it.

All tests are passing now:

…NSG for a subnet

azurecla · 2014-12-05T01:23:18Z

Hi @Dud5, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (edmunoz). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

ogail · 2014-12-05T04:17:56Z

src/ServiceManagement/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -78,9 +78,9 @@
    <Reference Include="Microsoft.WindowsAzure.Common.NetFramework">
      <HintPath>..\..\..\packages\Microsoft.WindowsAzure.Common.1.4.1\lib\net45\Microsoft.WindowsAzure.Common.NetFramework.dll</HintPath>
    </Reference>
-    <Reference Include="Microsoft.WindowsAzure.Management, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+    <Reference Include="Microsoft.WindowsAzure.Management, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


Please verify that this package is updated for all projects in AzurePowerShell solution

All other packages.config had been updated to 2.1.0 already and this one was missed.

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet

Merge master -> dev for release -0.8.13

Help content for Storage and Network cmdlets

Crp2

Dev

.

Fix bug 2074697 - Set-ASSDevice silently terminates when no optional par...

TestCases

pr from parent

Also added tests from CR: 1. Need to add a scenario for installing 2 named profiles side by side and verifying that we can select each 2. removing a named profile when multiple profiles are installed 3. Uninstalling all profiles

UpdateAdmin, SubAdmin ps1xmls, fixes

* ANF-243 update to R5 RP 2019-07-01 API (#28) - nfsv4 renamed to nfsv4.1 - snapshot cration date renamed to created * ANF-243 update to 2019-07-01 remove record

Fabric.Admin powershell Autorest Phase 3

…zure#527) * Add initial structure for AZ HPC Cache PowerShell Cmdlets. (Azure#1) * Add initial structure for AZ HPC Cache PowerShell Cmdlets. * Adding empty folder layout. * Update project reference for Test project of HPC Cache (Azure#2) * Initial commit of clients / first mock cmdlet (Azure#3) * Initial commit of clients / first mock cmdlet * Initial commit of clients / first mock cmdlet * Rename Client, Remove unnecessary files, return skulist in azure cmdlet * Remove utilities * Add classes to wrap .NET SDK type object. (Azure#4) * Create wrapper for SDK management client (Azure#5) * Fix GetAzSku wrt client changes. * Restructure base cmdlet and mangement client class. * Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (Azure#6) * More commands and start of test framework Move all logic out of hpc cache client to the commandlets More commands and start of test framework Updated commands using new client fix rebase fix spacing fix comments remove vars * Test Framework working, add comments to code * Help text files * Updates to cmdlet New-AzHpcCache * Update cmdlet Get-AzHpcCache * Update cmdlet Get-AzHpcCacheUsageModels * Update cmdlet Get-AzHpcCacheSku * Update cmdlet Remove-AzHpcCache * Cmdlet Update-AzHpcCache and help file * Changes made for code review * Start-AzHpcCache Cmdlet (Azure#8) * Add support for Start-AzHpcCache. * Adds resource designer for the project. * Adds assembly info for the project. * Remove unused imports * Remove .keep files as they are no longer required. * Use resource designer to handle strings in remove hpc cache cmdlet. * Fix namespace and add project reference to test project. * Prefix with this for local references for better code readability. * Fix argument validation. * Add synopsis for start hpc cache cmdlet help file. * Update Sku Test * Fix formatting based on StyleCop * Change output type of start cmdlet (Azure#12) * Flush-AzHpcCache cmdlet (Azure#11) Add FlushAzHpcCache.cs and Flush-AzHpcCache.md Update Resources files. Update AzHpcCache.md to include flush markdown file. Update psd1 file to include new command. * Add support for stop HPC cache cmdlet. (Azure#13) * Add support for stop HPC cache cmdlet. * Fix typos * Cmdlet: Remove Storage Target * Cmdlet: Upgrade-AzHpcCache * Add AsJob parameter option for action commands (Azure#14) * UpgradeCache and RemoveStorageTarget edits * Add support for storage target create. (Azure#17) * Add PS wrapper classes required for storage targets. * Add help for create storage target. * Add new storage target cmdlet. * Update resource designer for storage target. * Get-AzHpcCacheStorageTarget cmdlet * Fix help.md files to have correct messages * PSHpcCache (Azure#16) * Update how cache is returned * Update what is sent into PSHpcCache.cs * Add enumberate Collection * Update help text and comments (Azure#19) * Adds support for Set-AzHpcStorageTarget. (Azure#20) * Add support for storage target update. * Add help for Set-AzHpcStorageTarget. * Add hook for update storage target in PSD file. * Fix typos in help and comments. * Change UpdateHpcCache to SetHpcCache. (Azure#21) * Fix UpdateHpcCache to SetHpcCache * update help * Use Patch for Update, not Post - createOrUpdate * Change getST cmdlet to also get individual ST * Update test framework to use custom context and fixtures. (Azure#24) * Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext. * Update test class to use HpcCacheCollection and HpcCacheTestFixture. * Update PS file to test Get-AzHpcCache by resource group and name. * Add HpcCacheTestContext. * Add HpcCacheCollection. * Add HpcCacheTestFixture. * Add cache helper. * Add constants. * Add support to handle ENV vars from constants. * Add utilities required for fixture and custom context. * Adds storage account and storage target fixture. (Azure#25) * Add CLFS storage target and get storage target support. * Add StorageTargetName constant. * Add StorageTargetName ENV var. * Add Retry method and Aggregate exception handler. * Add storage account fixture. * Add storage account helper. * Add example storage target cmdlet test. * Update help text in SetAzHpcStorageTarget.cs (Azure#26) Update help text for cmdlet SetAzHpcCacheStorageTarget. * Fix help.md files and help messages * Fix for storage target update cmdlet. (Azure#28) * Add Cache, StorageTarget, and Operations tests * If incorrect value is entered, return inner exception body message * For Get and Remove - return inner exception body message * Fix formatting / Fix Descriptions / Fix Typos (Azure#32) * Fix formatting using stylecon * Flush cmdlet updates * Get-AzHpcCache cmdlet updates * Get-AzHpcCacheSku cmdlet updates * Get-AzHpcCacheStorageTarget cmdlet updates * Get-AzHpcCacheUsageModels cmdlet updates * New-AzHpcCache cmdlet updates * Remove-AzHpcCache cmdlet updates * Remove-AzHpcCacheStorageCache cmdlet updates * Set-AzHpcCache cmdlet updates * Start-AzHpcCache cmdlet updates * Stop-AzHpcCache cmdlet updates * Upgrade-AzHpcCache cmdlet updates * New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates * Fix mockContext for fixtures. (Azure#34) * Add required packages to test project. * Add assembly info for test project. * Fix references for resource manager. * Remove constructor overloading & fix mockContext, also fix references for resource manager * Dispose the context in StorageAccountFixture and fix the mockContext. * Add storage account name constant (Azure#35) * Add StorageAccountName constant. * Fix Context calling * Add recorded tests (Azure#33) * Add recorded tests * Rename folder * Revert "Add storage account name constant (Azure#35)" (Azure#36) This reverts commit 2ac58a8. * Revert "Fix mockContext for fixtures. (Azure#34)" (Azure#37) This reverts commit 768ba77. * Fix Context (Azure#38) * Add assebly for tests project. (Azure#39) * Remove completed TODO check. (Azure#40) * Add fake help urls to make CI task pass (Azure#41) * Remove completed TODO check. * Add fake online documentation URL to make CI task pass. * Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (Azure#42) * Fix CI task related issues (Azure#43) * Remove unused imports * Fix package references * Update session records to use correct API versions. * Package Changes / Resource Name Completer / Change Log and Solution (Azure#44) * Update ChangeLog * move packages to test * Fix solution file, add ResourceGroupCompleter to cmdlets * move all packages * Update changelog to preview * Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (Azure#45) * Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test * fix flush comments * Fix StartAzHpcCache to include input obj and resourceId * Fix StopAzHpcCache to include input obj and resourceId * Fix UpgradeAzHpcCache to include input obj and resourceId * test changes * fix help message for cmdlets * Add Alias and resource name completer for get cache & get storage target. (Azure#46) * Add CacheName as an alias & use ResourceNameCompleter. * Add StorageTargetName as an alias and use ResourceNameCompleter. * Alias initialization * Get storage target support pipeline cache input. * New and Set cmdlets (Azure#47) * update tests * update NewAzHpcCache to have should process * update Set cmdlet to use obj/resource Id and shouldProcess * remove resourceId from Set * update resouce designer * Update help files (Azure#48) * Fix reference * Update help files * Use CheckIn type for tests. (Azure#49) * Add CacheName and StorageTargetName alias. (Azure#50) * Update Alias in help * Add CacheName alias and help text for parameters. * Add StorageTargetName alias. * Formatting changes. * Add description to psd * Remove whitespaces. * rename files for linux (Azure#51) * Add shouldProcess to required cmdlets and update junction parameter. (Azure#52) * Add shouldProcess parameter * Modify tests to honor force parameter * Update help text * Update usage model cmdlet name. * Update help for all cmdlets to include whatIf Co-authored-by: Rebecca Makar <rebeccalmakar@gmail.com> Co-authored-by: Rebecca Makar <remakar@microsoft.com>

…01 (#11790) * [HPC-Cache] On-boarding of PowerShell Cmdlets for HPC Cache service. (#527) * Add initial structure for AZ HPC Cache PowerShell Cmdlets. (#1) * Add initial structure for AZ HPC Cache PowerShell Cmdlets. * Adding empty folder layout. * Update project reference for Test project of HPC Cache (#2) * Initial commit of clients / first mock cmdlet (#3) * Initial commit of clients / first mock cmdlet * Initial commit of clients / first mock cmdlet * Rename Client, Remove unnecessary files, return skulist in azure cmdlet * Remove utilities * Add classes to wrap .NET SDK type object. (#4) * Create wrapper for SDK management client (#5) * Fix GetAzSku wrt client changes. * Restructure base cmdlet and mangement client class. * Test Framework, Additional Cmdlets, Sku Object, Formatting Fixes (#6) * More commands and start of test framework Move all logic out of hpc cache client to the commandlets More commands and start of test framework Updated commands using new client fix rebase fix spacing fix comments remove vars * Test Framework working, add comments to code * Help text files * Updates to cmdlet New-AzHpcCache * Update cmdlet Get-AzHpcCache * Update cmdlet Get-AzHpcCacheUsageModels * Update cmdlet Get-AzHpcCacheSku * Update cmdlet Remove-AzHpcCache * Cmdlet Update-AzHpcCache and help file * Changes made for code review * Start-AzHpcCache Cmdlet (#8) * Add support for Start-AzHpcCache. * Adds resource designer for the project. * Adds assembly info for the project. * Remove unused imports * Remove .keep files as they are no longer required. * Use resource designer to handle strings in remove hpc cache cmdlet. * Fix namespace and add project reference to test project. * Prefix with this for local references for better code readability. * Fix argument validation. * Add synopsis for start hpc cache cmdlet help file. * Update Sku Test * Fix formatting based on StyleCop * Change output type of start cmdlet (#12) * Flush-AzHpcCache cmdlet (#11) Add FlushAzHpcCache.cs and Flush-AzHpcCache.md Update Resources files. Update AzHpcCache.md to include flush markdown file. Update psd1 file to include new command. * Add support for stop HPC cache cmdlet. (#13) * Add support for stop HPC cache cmdlet. * Fix typos * Cmdlet: Remove Storage Target * Cmdlet: Upgrade-AzHpcCache * Add AsJob parameter option for action commands (#14) * UpgradeCache and RemoveStorageTarget edits * Add support for storage target create. (#17) * Add PS wrapper classes required for storage targets. * Add help for create storage target. * Add new storage target cmdlet. * Update resource designer for storage target. * Get-AzHpcCacheStorageTarget cmdlet * Fix help.md files to have correct messages * PSHpcCache (#16) * Update how cache is returned * Update what is sent into PSHpcCache.cs * Add enumberate Collection * Update help text and comments (#19) * Adds support for Set-AzHpcStorageTarget. (#20) * Add support for storage target update. * Add help for Set-AzHpcStorageTarget. * Add hook for update storage target in PSD file. * Fix typos in help and comments. * Change UpdateHpcCache to SetHpcCache. (#21) * Fix UpdateHpcCache to SetHpcCache * update help * Use Patch for Update, not Post - createOrUpdate * Change getST cmdlet to also get individual ST * Update test framework to use custom context and fixtures. (#24) * Modify HpcCacheController to use RMTestBase base class and use HpcCacheTestContext. * Update test class to use HpcCacheCollection and HpcCacheTestFixture. * Update PS file to test Get-AzHpcCache by resource group and name. * Add HpcCacheTestContext. * Add HpcCacheCollection. * Add HpcCacheTestFixture. * Add cache helper. * Add constants. * Add support to handle ENV vars from constants. * Add utilities required for fixture and custom context. * Adds storage account and storage target fixture. (#25) * Add CLFS storage target and get storage target support. * Add StorageTargetName constant. * Add StorageTargetName ENV var. * Add Retry method and Aggregate exception handler. * Add storage account fixture. * Add storage account helper. * Add example storage target cmdlet test. * Update help text in SetAzHpcStorageTarget.cs (#26) Update help text for cmdlet SetAzHpcCacheStorageTarget. * Fix help.md files and help messages * Fix for storage target update cmdlet. (#28) * Add Cache, StorageTarget, and Operations tests * If incorrect value is entered, return inner exception body message * For Get and Remove - return inner exception body message * Fix formatting / Fix Descriptions / Fix Typos (#32) * Fix formatting using stylecon * Flush cmdlet updates * Get-AzHpcCache cmdlet updates * Get-AzHpcCacheSku cmdlet updates * Get-AzHpcCacheStorageTarget cmdlet updates * Get-AzHpcCacheUsageModels cmdlet updates * New-AzHpcCache cmdlet updates * Remove-AzHpcCache cmdlet updates * Remove-AzHpcCacheStorageCache cmdlet updates * Set-AzHpcCache cmdlet updates * Start-AzHpcCache cmdlet updates * Stop-AzHpcCache cmdlet updates * Upgrade-AzHpcCache cmdlet updates * New-AzHpcCacheStorageTarget and Set-AzHpcCacheStorageTarget cmdlet updates * Fix mockContext for fixtures. (#34) * Add required packages to test project. * Add assembly info for test project. * Fix references for resource manager. * Remove constructor overloading & fix mockContext, also fix references for resource manager * Dispose the context in StorageAccountFixture and fix the mockContext. * Add storage account name constant (#35) * Add StorageAccountName constant. * Fix Context calling * Add recorded tests (#33) * Add recorded tests * Rename folder * Revert "Add storage account name constant (#35)" (#36) This reverts commit 2ac58a8. * Revert "Fix mockContext for fixtures. (#34)" (#37) This reverts commit 768ba77. * Fix Context (#38) * Add assebly for tests project. (#39) * Remove completed TODO check. (#40) * Add fake help urls to make CI task pass (#41) * Remove completed TODO check. * Add fake online documentation URL to make CI task pass. * Update help files to fix fake URLS. it does not like fake servie & cmdlet name. (#42) * Fix CI task related issues (#43) * Remove unused imports * Fix package references * Update session records to use correct API versions. * Package Changes / Resource Name Completer / Change Log and Solution (#44) * Update ChangeLog * move packages to test * Fix solution file, add ResourceGroupCompleter to cmdlets * move all packages * Update changelog to preview * Add inputobj and resourceId params to Start/Stop/Flush/Upgrade. Update CacheName to name (#45) * Update Flush cmdlet to have InputObj and ResourceId, Update cacheName to Name, update test * fix flush comments * Fix StartAzHpcCache to include input obj and resourceId * Fix StopAzHpcCache to include input obj and resourceId * Fix UpgradeAzHpcCache to include input obj and resourceId * test changes * fix help message for cmdlets * Add Alias and resource name completer for get cache & get storage target. (#46) * Add CacheName as an alias & use ResourceNameCompleter. * Add StorageTargetName as an alias and use ResourceNameCompleter. * Alias initialization * Get storage target support pipeline cache input. * New and Set cmdlets (#47) * update tests * update NewAzHpcCache to have should process * update Set cmdlet to use obj/resource Id and shouldProcess * remove resourceId from Set * update resouce designer * Update help files (#48) * Fix reference * Update help files * Use CheckIn type for tests. (#49) * Add CacheName and StorageTargetName alias. (#50) * Update Alias in help * Add CacheName alias and help text for parameters. * Add StorageTargetName alias. * Formatting changes. * Add description to psd * Remove whitespaces. * rename files for linux (#51) * Add shouldProcess to required cmdlets and update junction parameter. (#52) * Add shouldProcess parameter * Modify tests to honor force parameter * Update help text * Update usage model cmdlet name. * Update help for all cmdlets to include whatIf Co-authored-by: Rebecca Makar <rebeccalmakar@gmail.com> Co-authored-by: Rebecca Makar <remakar@microsoft.com> * Change StorageCache folder name to HPCCache and modify Upgrade cache cmdlet … (#539) * Change StorageCache folder name to HPCCache and modify Upgrade cache cmdlet. * Update Az.HPCCache.psd1 Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * Release-2020-04-28-HPCCache * Add mapping rule for HPCCache * Remove Flush-AzHpcCache as Flush is not approved PS verb. * Add default parameter set for storage target cmdlets and output type for get usage model cmdlet. * Use parameter sets for Update-AzHpcCache * Remove prerelease string from .psd file. Co-authored-by: Rebecca Makar <rebeccalmakar@gmail.com> Co-authored-by: Rebecca Makar <remakar@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: msJinLei <lei.jin@microsoft.com>

Add test cases and examples of monitor solutions.

Update CDN object command for OriginGroup

Update regression tests

Ed Munoz added 4 commits December 4, 2014 16:43

Update Network.Test to WindowsAzure.Management.Common 2.1.0

b5abc36

Add test for the bug fix.

3b39092

Rethrow exception if the exception doesn't mean we are replacing the …

805fe28

…NSG for a subnet

Re-record all NSG scenario tests, including the new one.

259915e

azurecla added the cla-not-required label Dec 5, 2014

ogail reviewed Dec 5, 2014
View reviewed changes

ogail added a commit that referenced this pull request Dec 5, 2014

Merge pull request #28 from dud5/nsgbugrethrow

17ea233

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet

ogail merged commit 17ea233 into Azure:dev Dec 5, 2014

ogail added a commit to ogail/azure-powershell that referenced this pull request Jan 12, 2015

Merge pull request Azure#28 from Azure/master

b069bac

Merge master -> dev for release -0.8.13

ogail pushed a commit that referenced this pull request Feb 25, 2015

Merge pull request #28 from AsrOneSdk/sriramvu-dev

0fe837a

Help content for Storage and Network cmdlets

akromm-zz pushed a commit to akromm-zz/azure-powershell that referenced this pull request Apr 18, 2015

Merge pull request Azure#28 from huangpf/crp2

79cd9ef

Crp2

huangpf referenced this pull request in huangpf/azure-powershell Jun 19, 2015

Merge pull request #28 from hyonholee/dev

cf4f5d9

Dev

huangpf added a commit that referenced this pull request Jul 1, 2015

Merge pull request #28 from Azure/dev

7d4cfda

.

ogail pushed a commit that referenced this pull request Jul 7, 2015

Merge pull request #28 from AzCiS/bugfix-2074697

d860931

Fix bug 2074697 - Set-ASSDevice silently terminates when no optional par...

stankovski pushed a commit that referenced this pull request Jul 10, 2015

Merge pull request #28 from MabOneSdk/panbha15

a3cfeae

TestCases

jianghaolu pushed a commit that referenced this pull request Sep 4, 2015

Merge pull request #28 from Azure/dev

2c2d061

pr from parent

bganapa pushed a commit to bganapa/azure-powershell that referenced this pull request Apr 12, 2018

Merge pull request Azure#28 from deathly809/mg-azs-admin2

c97807d

UpdateAdmin, SubAdmin ps1xmls, fixes

wyunchi-ms pushed a commit that referenced this pull request Nov 6, 2019

Update to R5 RP 2019-07-01 API (#10445)

f7382d9

* ANF-243 update to R5 RP 2019-07-01 API (#28) - nfsv4 renamed to nfsv4.1 - snapshot cration date renamed to created * ANF-243 update to 2019-07-01 remove record

ionuttulai pushed a commit to ionuttulai/azure-powershell that referenced this pull request Mar 4, 2020

Merge pull request Azure#28 from LingyunSu/dev

22620e3

Fabric.Admin powershell Autorest Phase 3

romahamu added a commit to romahamu/azure-powershell that referenced this pull request May 4, 2020

Fix for storage target update cmdlet. (Azure#28)

f2c86db

isra-fel pushed a commit to isra-fel/azure-powershell that referenced this pull request Jun 30, 2020

Merge pull request Azure#28 from LucasYao93/lucas/MonitorSolutions-dev

ff2ec9b

Add test cases and examples of monitor solutions.

isra-fel pushed a commit that referenced this pull request Apr 25, 2022

Merge pull request #28 from ChenglongLiu/feature/Cdndev

5a1b023

Update CDN object command for OriginGroup

yifanz7 pushed a commit to yifanz7/azure-powershell that referenced this pull request May 16, 2023

Merge pull request Azure#28 from wastoresh/testupdate

b03208a

Update regression tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet #28

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet #28

edumunoz commented Dec 5, 2014

azurecla commented Dec 5, 2014

ogail Dec 5, 2014

edumunoz Dec 5, 2014

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet #28

Rethrow exception in Set-AzureNetworkSecurityGroupToSubnet #28

Conversation

edumunoz commented Dec 5, 2014

azurecla commented Dec 5, 2014

ogail Dec 5, 2014

Choose a reason for hiding this comment

edumunoz Dec 5, 2014

Choose a reason for hiding this comment