Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation network preview #25065

Conversation

bhupeshbhatt1985
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

NoriZC and others added 30 commits December 14, 2023 15:59
…zure#23732)

* add approle api in local yaml

* add approle api in local yaml

* customize New-AzAdServiceprincipalAppRoleAssignment

* app role

* Delete src/Resources/MSGraph.Autorest/test/Get-AzADServicePrincipalAppRoleAssignedTo.Tests.ps1

* Delete src/Resources/MSGraph.Autorest/test/Remove-AzADServicePrincipalAppRoleAssignedTo.Tests.ps1

* Delete src/Resources/MSGraph.Autorest/test/Update-AzADServicePrincipalAppRoleAssignedTo.Tests.ps1

* add examples

* remove useless parameters

* Update New-AzADServicePrincipalAppRoleAssignment.Tests.ps1

* update

* Update Get-AzADApplication.ps1

* Update Get-AzADApplication.ps1

* change output ux, resolve comments
* Rename SmbFileShare endpoint cmdlets

* update remaining

* Remove old test file
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* generate Fleet by autorest, code design, example, test

* update examples

* update doc

* Update README.md

* fix typo
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* Update the folder structure of Workloads

* Update the folder structure of Workloads

* Update the folder structure of Workloads
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* Removed Directives, ran autorest, deleted 3 custom appAttach cmdlets

* ran first test with failures on user session, remove

* Added successful remove session host recording

* All tests pass

* fixed removed session host test

* Removed changes to json file in Tools Common

* Removed extra space

* Find all missed one somehow

* Added additional breaking change suppression
* New Version 1.0.0 for Azure Workloads Module

New Version 1.0.0 for Azure Workloads Module

* Update New-AzWorkloadsSapVirtualInstance.Tests.ps1

Added to run the checks again

* Update README.md

* Updating Docs and Test cases

* Update New-AzWorkloadsSapVirtualInstance.Tests.ps1

* Fixing Stop Database test

* correcting error for Remove SVI

* Fixing the issue with New SVI
Co-authored-by: azurepowershell <azurepowershell@ms.com>
… vaults (Azure#23818)

* Added support for Cross region restore for Backup vaults

* fixed Analyse issues

* re-recorded failed tests

* resolved issue with HttpPipelinePrepend

* added no-inline
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* Azure Monitor Metrics Data Plane API 2023-05-01-Preview Client tools

* [MetricBatch] change the module name

Make module name the same as folder name

* Update README.md

* Update to stable version

* CI failure Test

* Remove Metric manage plane

---------

Co-authored-by: Xiaogang <xidi@microsoft.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
YanaXu and others added 26 commits May 8, 2024 09:22
* init add powershell cmdlet

* add customization for filedetails

* correct readme to include file workspace create

* add custom cmdlet for creating and uploading the file

* chunking logic for larger files

* add error for custom cmdlet when file too big

* combined cmdlets

* edit custom file upload command to not use default subscriptionid

* no default value for subid in custom file upload

* separate subscription and no subscription commands

* remove comments from combined cmd for file

* fix cmd

* custom no subscription file upload commands

* autogen docs for no sub file upload

* hide individual file commands

* add back workspace commands

* add name as alias for fileworkspacename fileworkspacesnosubscription

* remove update files and add alias for nosubscription file commands

* tests for get service

* tests for problem classification

* try adding erroractionpreference = stop

* tests for new file workspace

* tests for get file workspace

* more tests

* add tests for new file and upload, removefile name as a parameter

* remove new files no subscription

* tests for get file

* erroraction stop

* remove unnecessary comments and print statements

* docs for get support service

* problem classification docs

* add titles

* documentation for file workspace commands

* documentation for file/file workspace cmdlets

* documentation for checkNameAvailability

* added tests and documentation for operations, support ticket, communication and chat transcript cmdlets

* added examples for operations, support ticket, communication and chat transcript cmdlets

* resolve merge conflicts

* resolved PR comments

* get conflict file changes from grhuang/azsupport-autorest

* resolved merge conflict

* removed update communication sub and no sub scenarios

* Revert "removed update communication sub and no sub scenarios"

This reverts commit ccbfdee.

* removed update communication sub and no sub scenarios , updated readme

* make communiation and support ticket properties required in readme, edit get operation file name, edit calling internal cmdlets for file upload

* fix documentation

* fix top query

* add custom error handler

* consolidate list and get communicationsnosubscription and chattranscriptsnosubscription

* init changes to allow no subscription recording tests-need to use csp partner account in tenant 2e6a0c9f-986d-480e-ad4b-bdfddc047aba

* changes to not create new resources in playback

* remove custom error handler csharp

* init add changes to split subscription and no subscription tests

* update skip

* Update recordings

* update recordings

* add more examples to new-azsupportticket documentation

* update documentation and readme

* add directive back in

* make advanced diagnostic consent required

* Add custom error handling for New- and Update- cmdlets to print full details of error (Azure#9)

* Add custom error handler

* Add default filter to retrieve tickets from the past week for Get-AzSupportTickets and Get-AzSupportTicketsNoSubscription (Azure#10)

* add custom filtering for list support ticket if no filter is applied

* make transformations in swagger in readme to make enrollment id not readonly and show isTempTicket (Azure#11)

* Add argument completer (Azure#12)

* add argument completers

* add quotes to argument completers

* remove repeated time zone

* Regenerate powershell module with GA swagger (Azure#13)

* Rerecord tests using GA version (Azure#14)

* add tests for file size (will add recordings once Ga swagger available)

* Regenerate powershell module with GA swagger

* Rerecord tests with GA version

* Fix documentation

* fix url for file upload

---------

Co-authored-by: Grace Huang (from Dev Box) <grhuang@microsoft.com>
Co-authored-by: grhuangmsft <103289214+grhuangmsft@users.noreply.github.com>
Co-authored-by: Shreya Kumar <shreyakumar@microsoft.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
…zure#24221)

* Move Policy CRUD cmdlets to autorest generation: fixes (Azure#23518)

* Set all tests to -LiveOnly
Add back some test infrastructure fixes that were lost
Improve parameter handling for Remove-AzPolicySetDefinition

* Move to supported way of sharing Helpers.psm1 file

* Switch to recommended approach for shared functions

* Update to autorest 4.x (Azure#24319)

Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Update Policy CRUD cmdlets (Azure#24361)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix calculation for $testFilesFolder on macOS/linux (Azure#24408)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-* (Azure#24507)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe (Azure#24540)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Apply changes to support -Playback mode (Azure#24555)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* move creation of resource group to utils.ps1

* Test tweaks (Azure#24566)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* fix test cases

* Correct location handling, fix tests and consistency (Azure#24573)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* Updates for consistency and to fix tests
Make changes to ensure consistent and valid handling of $location
Rerecord tests

* Fix bad merge
Rerecord two test files

* Re-record tests

* remove unnecessary script

* change cached location with a more unique name

* update execution of util script

* fix positional parameters generated when only default parameter set

* fix erroraction for Get-AzPolicyDefinition

* Apply feedback (Azure#24757)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

* Fix $testFilesFolder calculation to work on macOS/linux.

* Hide generated parameter sets for New-*
Correct definitions, validation, and tests for New-AzPolicyAssignment parameters
Re-record all tests

* Replace Get-AzContext with Utils\Get-SubscriptionIdTestSafe
Move to autorest 4.0.690
Update managed identity properties to match generation changes
Remove several parameter transforms no longer needed
Rerecord all tests
91 tests still failing on -Playback with the same signature

* Remove location completer from exports/docs/examples/help

* Improve location completer tests

* Remove transforms for Scope and Id parameters no longer needed
Update cmdlets to use Scope and Id directly
Rerecord all tests
All tests pass in -Record mode
Failures in -Playback mode unchanged

* Change location completer to lazy load (vs. module load)
Preserve "extra" input parameters in Update-* calls to Get-* in order to support -Playback test mode
Tag test files that don't support -Playback mode as LiveOnly
Rerecord all recording files

* Minor updates for consistency
Rerecord all tests
Move 4 test files back to LiveOnly

* Updates for consistency and to fix tests
Make changes to ensure consistent and valid handling of $location
Rerecord tests

* Fix bad merge
Rerecord two test files

* Re-record tests

* Implement feedback:
 - Add ResourceId to Get-AzPolicy[Set]Definition
 - Change -BuiltIn to -Builtin
 - Add -InputObject parameter to Update-* cmdlets
 - Control ErrorAction behavior for Get-AzPolicy[Set]Definition
Deprecate the -BackwardCompatible switch

* sync static analysis exceptions

* remove redundant

* added file accidentally removed

---------

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Change parsing logic in ATC custom cmdlet

* Add if check

* add if check

* Minor change

* Add UT
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* feature storage action 20240131

* Storage Action feature test cases and examples

* Storage Action test added

* Added swagger fix

* Update commit id from swagger main

* Update commit

* Update example

* Update src/StorageAction/StorageAction.Autorest/docs/New-AzStorageActionTask.md

* Update src/StorageAction/StorageAction.Autorest/docs/New-AzStorageActionTask.md

* Update example

---------

Co-authored-by: Yan Xu <yanxu1@microsoft.com>
* Upgrade managed identity for Custom Location module

* Fix and remove custom cmdlets

* Add New custom location example exception

* Update CustomLocation examples
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* Ran autorest

* update repo path in README.md file (input-file property)

* add/fix examples

* update docs

* added test recordings and updates from custom files

* fix example and docs errors and re-ran all recordings

* fix some examples and docs
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Copy link

azure-client-tools-bot-prd bot commented Jun 3, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzNetworkSecurityPerimeter Get-AzNetworkSecurityPerimeter Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeter Get-AzNetworkSecurityPerimeter changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterAccessRule Get-AzNetworkSecurityPerimeterAccessRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterAccessRule Get-AzNetworkSecurityPerimeterAccessRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterAssociableResourceType Get-AzNetworkSecurityPerimeterAssociableResourceType Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterAssociableResourceType Get-AzNetworkSecurityPerimeterAssociableResourceType changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterAssociation Get-AzNetworkSecurityPerimeterAssociation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterAssociation Get-AzNetworkSecurityPerimeterAssociation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterLink Get-AzNetworkSecurityPerimeterLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterLink Get-AzNetworkSecurityPerimeterLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterLinkReference Get-AzNetworkSecurityPerimeterLinkReference Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterLinkReference Get-AzNetworkSecurityPerimeterLinkReference changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzNetworkSecurityPerimeterProfile Get-AzNetworkSecurityPerimeterProfile Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzNetworkSecurityPerimeterProfile Get-AzNetworkSecurityPerimeterProfile changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Invoke-AzNetworkSecurityPerimeterNspAccessRulesReconcile 2 2 Mismatched_Parameter_Value_Type Invoke-AzNetworkSecurityPerimeterNspAccessRulesReconcile -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAccessRule.(Command).
⚠️ Invoke-AzNetworkSecurityPerimeterNspAssociationReconcile 2 2 Mismatched_Parameter_Value_Type Invoke-AzNetworkSecurityPerimeterNspAssociationReconcile -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAssociation.(Command).
⚠️ Update-AzNetworkSecurityPerimeter 2 2 Mismatched_Parameter_Value_Type Update-AzNetworkSecurityPerimeter -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeter.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Network. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

@NoriZC NoriZC merged commit aff8ad2 into Azure:generation-network-preview Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.