Skip to content

Add support for V12 SQL Database in Start-AzureSqlDatabaseExport #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivanz
Copy link

@ivanz ivanz commented Mar 3, 2015

Remove the hardcoded use of pre-v12 context type in StartAzureSqlDatabaseExport:

  • Use a new ISqlCredentialsDataServiceContext implemented by pre-v12 and v12 data contexts in the command
  • Enable 'SqlAuthenticationCredentials' to be instantiated with a plain-text password for when the consumer doesn't have PSCredentials. Creates SecureString internally.

Fixes Azure/azure-sdk-tools#3086 and also #136

Ivan Zlatev added 2 commits March 3, 2015 13:57
…baseExport:

 - Use a new ISqlCredentialsDataServiceContext implemented by pre-v12 and v12 data contexts in the command
 - Enable 'SqlAuthenticationCredentials' to be instantiated with a plain-text password for when the consumer doesn't have PSCredentials. Creates SecureString internally.

Fixes Azure#3086
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Mar 3, 2015

Hi @ivanz, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@ivanz
Copy link
Author

ivanz commented Mar 3, 2015

Please have a look at this pull request and let me know if there is any feedback. I will sort out the CLA shortly. Thanks.

@amarzavery
Copy link
Contributor

@azuresdkci add to whitelist

@amarzavery
Copy link
Contributor

@ivanz we do not accept PR in Master branch. Please rebase it to the dev branch

@amarzavery amarzavery closed this Mar 3, 2015
@ivanz
Copy link
Author

ivanz commented Mar 3, 2015

@amarzavery Ahhh. That's unfortunate to find out at this point in the game, because as it turns out that you guys have fixed the problem in pretty much the same way as me. Anyway - you may consider closing the issues I referenced, because they are resolved in the dev branch.

@amarzavery
Copy link
Contributor

@ivanz - We cut a release branch from the dev branch. Once everything looks good in the release branch then as a part of end of release activities we merge from release->master->dev. That is the general process. So things in dev will be in master in few days as we are in the process of releasing the next version of PS.

markcowl added a commit to markcowl/azure-powershell that referenced this pull request May 4, 2015
Fix the percent complete for transparent data encryption activity
@CloudIRE
Copy link

CloudIRE commented May 8, 2015

Is the version of PowerShell released that solves this issue yet @amarzavery?

AzureRT pushed a commit to AzureRT/azure-powershell that referenced this pull request Nov 26, 2015
markcowl pushed a commit that referenced this pull request Apr 28, 2016
Checkin acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants