-
Notifications
You must be signed in to change notification settings - Fork 4k
Add support for V12 SQL Database in Start-AzureSqlDatabaseExport #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for V12 SQL Database in Start-AzureSqlDatabaseExport #215
Conversation
…henticationCredentials'
…baseExport: - Use a new ISqlCredentialsDataServiceContext implemented by pre-v12 and v12 data contexts in the command - Enable 'SqlAuthenticationCredentials' to be instantiated with a plain-text password for when the consumer doesn't have PSCredentials. Creates SecureString internally. Fixes Azure#3086
Can one of the admins verify this patch? |
Hi @ivanz, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
Please have a look at this pull request and let me know if there is any feedback. I will sort out the CLA shortly. Thanks. |
@azuresdkci add to whitelist |
@ivanz we do not accept PR in Master branch. Please rebase it to the dev branch |
@amarzavery Ahhh. That's unfortunate to find out at this point in the game, because as it turns out that you guys have fixed the problem in pretty much the same way as me. Anyway - you may consider closing the issues I referenced, because they are resolved in the dev branch. |
@ivanz - We cut a release branch from the dev branch. Once everything looks good in the release branch then as a part of end of release activities we merge from release->master->dev. That is the general process. So things in dev will be in master in few days as we are in the process of releasing the next version of PS. |
Fix the percent complete for transparent data encryption activity
Is the version of PowerShell released that solves this issue yet @amarzavery? |
Remove the hardcoded use of pre-v12 context type in StartAzureSqlDatabaseExport:
Fixes Azure/azure-sdk-tools#3086 and also #136