-
Notifications
You must be signed in to change notification settings - Fork 4k
[Release-1.2.2] ADL Upgrade to AutoRest #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This moves all cmdlets for DataLake over to AutoRest C# clients.
# Conflicts: # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/packages.config # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands.DataLakeAnalytics.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/Commands.DataLakeStore.Test.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands.DataLakeStore.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/packages.config
removing DOP requirement.
# Conflicts: # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/ScenarioTests/AdlaTestsBase.cs # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/packages.config # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands.DataLakeAnalytics.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Models/DataLakeAnalyticsClient.cs # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/Commands.DataLakeStore.Test.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/ScenarioTests/AdlsTestsBase.cs # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands.DataLakeStore.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Models/DataLakeStoreClient.cs # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Models/DataLakeStoreFileSystemClient.cs # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/packages.config
also includes a new client creation method for ADL clients which have unique constructors to use.
Update ADL cmdlets to use the latest AutoRest packages Update ADL cmdlets to remove Expect100Continue for performance of data ingress Remove private packages from local feed Run all tests and ensure they continue to pass. Minor renaming fixes to make class names consistent with file names Fix spacing and parameter ordering to go along with AutoRest conventions.
# Conflicts: # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/Commands.DataLakeStore.Test.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/packages.config
cleanup usings.
and replace App.config
# Conflicts: # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/packages.config # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands.DataLakeAnalytics.csproj # src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/Commands.DataLakeStore.Test.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/packages.config # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands.DataLakeStore.csproj # src/ResourceManager/DataLakeStore/Commands.DataLakeStore/packages.config
UPDATED AFTER ADDRESSING HOVSEP'S COMMENTS: PowerShell Sign: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/278/ |
/// <exception cref="System.ApplicationException"></exception> | ||
/// <exception cref="System.ArgumentException"> | ||
/// accountName | ||
/// or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this was a ghostDoc generation. I will fix it.
This is the PowerShell change to update ADL cmdlets to AutoRest. Rebasing the PR to the release branch instead of dev.